Remove the assumption that n/(k+1) is a multiple of 8 #1172
Conversation
str4d
added
A-pow
str4d
added this to the z8 release - core (excl. RPC) audit freeze, functional PoW milestone
|
When we are happy with this, I will open a new issue for fixing the implementation to match what we want to specify. |
|
|
||
| if (8*cByteLen == cBitLen) { | ||
| // We are colliding an integer number of bytes; hLen == N/8 | ||
| crypto_generichash_blake2b_final(&state, hash, hLen); |
There was a problem hiding this comment.
Keeping the hash call outside the if would probably result in easier-to-follow code.
There was a problem hiding this comment.
Note that even when we change the expansion method, the same expression should work for the hash output length in both cases.
|
ACK. The first commit has me as committer and Signed-off-by even though it's not identical to the code I wrote. In such cases can you recommit as you, and add "Author: Daira Hopwood" in the commit message, or some other way that reflects joint authorship, please? (There's no need to do this when fixing trivial conflicts in rebases, it's just that there are nontrivial changes here.) |
This version works, but generates the initial rows in a way that is not what we want to specify. See zcash#1175 for resolving this. Co-author: Daira Hopwood <daira@jacaranda.org>
str4d
force-pushed
the
1148-remove-equihash-collision-length-assumption
branch
from
eebbce5
to
036dcbd
Compare
|
Rebased on .latest and fixed the commit message. |
|
ACK |
|
ACK @zkbot r+ |
|
📌 Commit 036dcbd has been approved by |
…umption, r=bitcartel Remove the assumption that n/(k+1) is a multiple of 8 This version works, but generates the initial rows in a way that is probably not what we want to specify. Closes #1148
|
☀️ Test successful - zcash |
This version works, but generates the initial rows in a way that is probably
not what we want to specify.
Closes #1148