Improve speed and accuracy of zcbenchmark validatelargetx #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unncessarily create thousands of CTransaction objects.
bitcartel
added
I-performance
bitcartel
added this to the
z9 Release - RPC, Audit tasks, Testing improvements milestone
bitcartel
added
the
S-waiting-on-review
bitcartel
changed the title
|
ACK |
1 similar comment
|
ACK |
|
@zkbot r+ |
|
📌 Commit 75c2f26 has been approved by |
|
💥 Test timed out |
|
@zkbot r+ |
|
💡 This pull request was already approved, no need to approve it again.
|
|
📌 Commit 75c2f26 has been approved by |
|
@zkbot retry |
|
💥 Test timed out |
|
@zkbot retry |
|
@zkbot r+ |
|
🙀 |
zkbot
pushed a commit
that referenced
this pull request
Aug 14, 2016
…bfull Improve speed and accuracy of zcbenchmark validatelargetx The verification test, in a loop, passes `spending_tx` (a `CMutableTransaction`) to the constructor of `MutableTransactionSignatureChecker`, which immediately uses it to create a non-mutable `CTransaction` object, which is used for the actual verification process. Since `spending_tx` is not mutated during the verification loop & process, we can instead convert it to a `CTransaction` just once, and use it with `TransactionSignatureChecker`. This removes the time to create `CTransaction` objects from the benchmark itself. Results show an improvement in running time to complete the verification phase of the test and consistent times across z7 and z8 releases. ``` Benchmarks on i3 processor: z7 old 228.67205900 --> z7 new 49.27225200 z7 old 229.90048900 --> z7 new 48.38650700 z8 old 295.77963800 --> z8 new 48.37695100 z8 old 294.32640100 --> z8 new 49.93216100 ```
|
☀️ Test successful - zcash |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The verification test, in a loop, passes
spending_tx(aCMutableTransaction) to the constructor ofMutableTransactionSignatureChecker, which immediately uses it to create a non-mutableCTransactionobject, which is used for the actual verification process.Since
spending_txis not mutated during the verification loop & process, we can instead convert it to aCTransactionjust once, and use it withTransactionSignatureChecker.This removes the time to create
CTransactionobjects from the benchmark itself.Results show an improvement in running time to complete the verification phase of the test and consistent times across z7 and z8 releases.