New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add async rpc call z_sendmany #1271
Closed
bitcartel
wants to merge
22
commits into
zcash:zc.v0.11.2.latest
from
bitcartel:z8_rpc_async_rebase_z8rpckeys_1199keys_1199notes
Closed
[WIP] Add async rpc call z_sendmany #1271
bitcartel
wants to merge
22
commits into
zcash:zc.v0.11.2.latest
from
bitcartel:z8_rpc_async_rebase_z8rpckeys_1199keys_1199notes
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified RPC calls dumpwallet and importwallet to include spending keys.
taddr and zaddr. Restore behaviour of dumpwallet and importwallet to only handle taddr.
CWallet - GenerateNewZKey() - AddZKey() - LoadZKey() - LoadZKeyMetadata() CWalletDB - WriteZKey()
Fix incorrect method name used in error message.
z_importwallet, z_exportwallet z_importkey, z_exportkey z_listaddresses
Add z_getoperationstatus RPC command. Add z_sendmany RPC command (dummy implementation, does not send actual coins).
bitcartel
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Aug 17, 2016
Notes: Async queue class can have more than one worker (default) and this could be added as a conf option. Example output:
|
unncessarily create thousands of CTransaction objects.
Closing due to git voodoo. PR moves to #1274 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #1200
Depends on #1205 #1208 #1233