Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Add async rpc call z_sendmany #1271

Closed
wants to merge 22 commits into from
Closed

[WIP] Add async rpc call z_sendmany #1271

wants to merge 22 commits into from

Commits on Aug 9, 2016

  1. Add support for spending keys to the basic key store

    @str4d
    str4d committed Aug 9, 2016
    Configuration menu
    Copy the full SHA
    7c929cf View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2016

  1. Implemented RPC calls z_importkey, z_exportkey, z_getnewaddress. 

    Modified RPC calls dumpwallet and importwallet to include spending keys.
    @bitcartel
    bitcartel committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    f88f51f View commit details
    Browse the repository at this point in the history

  2. Add z_importwallet and z_exportwallet to handle keys for both 

    taddr and zaddr.  Restore behaviour of dumpwallet and importwallet
to only handle taddr.
    @bitcartel
    bitcartel committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    62eea0d View commit details
    Browse the repository at this point in the history

  3. Implemented z_listaddresses to return all the zaddr in the wallet.

    @bitcartel
    bitcartel committed Aug 10, 2016
    Configuration menu
    Copy the full SHA
    84ce3a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2016

  1. Add gtest to cover new methods in: 

    CWallet
- GenerateNewZKey()
- AddZKey()
- LoadZKey()
- LoadZKeyMetadata()
CWalletDB
- WriteZKey()
    @bitcartel
    bitcartel committed Aug 11, 2016
    Configuration menu
    Copy the full SHA
    65c02f9 View commit details
    Browse the repository at this point in the history

  2. Don't mark wallet as dirty if key already exists. 

    Fix incorrect method name used in error message.
    @bitcartel
    bitcartel committed Aug 11, 2016
    Configuration menu
    Copy the full SHA
    9155cc6 View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2016

  1. Added wallet rpc tests to cover: 

    z_importwallet, z_exportwallet
z_importkey, z_exportkey
z_listaddresses
    @bitcartel
    bitcartel committed Aug 13, 2016
    Configuration menu
    Copy the full SHA
    e57e5e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2016

  1. Merge AddSpendingKeyPaymentAddress into AddSpendingKey to simplify API

    @str4d @bitcartel
    str4d authored and bitcartel committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    4df3999 View commit details
    Browse the repository at this point in the history

  2. Consistent parameter naming

    @str4d @bitcartel
    str4d authored and bitcartel committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    8cec3de View commit details
    Browse the repository at this point in the history

  3. Add separate lock for SpendingKey key store operations

    @str4d @bitcartel
    str4d authored and bitcartel committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    d78026d View commit details
    Browse the repository at this point in the history

  4. Add async RPC queue and operation classes. 

    Add z_getoperationstatus RPC command.
Add z_sendmany RPC command (dummy implementation, does not send actual
coins).
    @bitcartel
    bitcartel committed Aug 17, 2016
    Configuration menu
    Copy the full SHA
    9a3a427 View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2016

  1. Fixes zcash#1193 so that during verification benchmarking it does not 

    unncessarily create thousands of CTransaction objects.
    @bitcartel
    bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    e2898aa View commit details
    Browse the repository at this point in the history

  2. Update variable.

    @bitcartel
    bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    2c27fb2 View commit details
    Browse the repository at this point in the history

  3. Update equihash.cpp 

    fix zcash#1214
    @bitcartel
    Robert C. Seacord authored and bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    c90e1f0 View commit details
    Browse the repository at this point in the history

  4. Update test_equihash.cpp

    @bitcartel
    Robert C. Seacord authored and bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    6701699 View commit details
    Browse the repository at this point in the history

  5. Disable hardening when building for coverage reports.

    @defuse @bitcartel
    defuse authored and bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    54c9d68 View commit details
    Browse the repository at this point in the history

  6. Rework test to check for failure to return a spending key

    @str4d @bitcartel
    str4d authored and bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    aa06d4a View commit details
    Browse the repository at this point in the history

  7. ASSERT -> EXPECT in test to get more info per test run about future r… 

    …egressions
    @str4d @bitcartel
    str4d authored and bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    b51672e View commit details
    Browse the repository at this point in the history

  8. Add wallet method for finding spendable Notes in a CTransaction

    @str4d @bitcartel
    str4d authored and bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    761d2a8 View commit details
    Browse the repository at this point in the history

  9. Store mapping between Notes and PaymentAddresses in CWalletTx

    @str4d @bitcartel
    str4d authored and bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    a423578 View commit details
    Browse the repository at this point in the history

  10. Cache ZCNoteDecryption objects for efficiency

    @str4d @bitcartel
    str4d authored and bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    f91ea7a View commit details
    Browse the repository at this point in the history

  11. Keep track of spent Notes, and detect and report conflicts

    @str4d @bitcartel
    str4d authored and bitcartel committed Aug 18, 2016
    Configuration menu
    Copy the full SHA
    2a263db View commit details
    Browse the repository at this point in the history