Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for centos and mac #1537

Closed
wants to merge 7 commits into from
Closed

Fix for centos and mac #1537

wants to merge 7 commits into from

Conversation

xaoseric
Copy link

Added fetch-params-mac.sh for mac users, and changed shasum to sha256sum redhat based os fix

@daira
Copy link
Contributor

daira commented Oct 15, 2016

Changing to sha256sum will fix some platforms and break others (see #776 and #1053 (comment)). We should instead try sha256sum and fall back to shasum -a 256 (as @ebfull originally suggested in #776 (comment) ).

@xaoseric
Copy link
Author

@daira the fetch-params-mac.sh file solves that issue as Ubuntu and Debian already have sha256sum support. 8a8fdeb

@xaoseric
Copy link
Author

@daira i did try playing around with your suggestion, couldn't get it to work though, so if you want to take a look at it, feel free

@daira
Copy link
Contributor

daira commented Oct 15, 2016

SHA256CMD="$(command -v sha256sum || echo shasum)"
SHA256ARGS="$(command -v sha256sum >/dev/null || echo '-a 256')"
"$SHA256CMD" $SHA256ARGS filename

(It's harder with the correct quoting; if we assumed that the path to sha256sum had no special characters then it would be simpler.)

@zkbot
Copy link
Contributor

zkbot commented Oct 24, 2016

☔ The latest upstream changes (presumably a885ee4) made this pull request unmergeable. Please resolve the merge conflicts.

@daira daira added this to the 1.0.0-rc3 milestone Oct 25, 2016
@daira
Copy link
Contributor

daira commented Oct 25, 2016

Superceded by #1628.

@daira daira closed this Oct 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants