Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag for enabling experimental features #2056

Merged
merged 2 commits into from Feb 10, 2017

Conversation

Projects
None yet
4 participants
@str4d
Copy link
Contributor

commented Jan 31, 2017

Closes #2035.

@str4d str4d added this to the 1.0.6 milestone Jan 31, 2017

@str4d str4d force-pushed the str4d:2035-experimental-mode branch from e8dc46f to 323824d Jan 31, 2017

@daira

This comment has been minimized.

Copy link
Contributor

commented Feb 8, 2017

I'm assuming this should not be reviewed yet because it has [WIP].

@str4d str4d changed the title [WIP] Add a flag for enabling experimental features Add a flag for enabling experimental features Feb 8, 2017

@str4d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 8, 2017

@daira ready for review, now that #2035 (comment) is addressed.

@bitcartel

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2017

utACK

@bitcartel bitcartel requested review from daira and ebfull Feb 9, 2017

@bitcartel bitcartel assigned bitcartel and str4d and unassigned bitcartel Feb 9, 2017

@@ -2002,7 +2002,7 @@ Value encryptwallet(const Array& params, bool fHelp)
if (!EnsureWalletIsAvailable(fHelp))
return Value::null;

auto fEnableWalletEncryption = GetBoolArg("-developerencryptwallet", false);
auto fEnableWalletEncryption = fExperimentalMode && GetBoolArg("-developerencryptwallet", false);

This comment has been minimized.

Copy link
@daira

daira Feb 9, 2017

Contributor

This silently ignores -developerencryptwallet when not in experimental mode. It should give an error.

This comment has been minimized.

Copy link
@daira

daira Feb 9, 2017

Contributor

Otherwise ut(ACK+cov).

This comment has been minimized.

Copy link
@str4d

str4d Feb 9, 2017

Author Contributor

Ah, you mean there should be an error saying "please enable -experimentalfeatures".

This comment has been minimized.

Copy link
@daira

daira Feb 9, 2017

Contributor

Given the check here, this change is no longer required. Does not block.

@bitcartel

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2017

@str4d Minor change requested in review from @daira

@str4d str4d force-pushed the str4d:2035-experimental-mode branch from e78ad14 to 6f049ed Feb 9, 2017

@str4d

This comment has been minimized.

Copy link
Contributor Author

commented Feb 9, 2017

@bitcartel @daira Amended commit to add an init check.

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Feb 9, 2017

☔️ The latest upstream changes (presumably #1965) made this pull request unmergeable. Please resolve the merge conflicts.

str4d added some commits Jan 31, 2017

@str4d str4d force-pushed the str4d:2035-experimental-mode branch from 6f049ed to b8eb377 Feb 9, 2017

@daira

daira approved these changes Feb 9, 2017

@bitcartel

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2017

ACK

@bitcartel

This comment has been minimized.

Copy link
Contributor

commented Feb 9, 2017

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Feb 9, 2017

📌 Commit b8eb377 has been approved by bitcartel

@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Feb 9, 2017

⌛️ Testing commit b8eb377 with merge 7d4ced9...

zkbot added a commit that referenced this pull request Feb 9, 2017

Auto merge of #2056 - str4d:2035-experimental-mode, r=bitcartel
Add a flag for enabling experimental features

Closes #2035.
@zkbot

This comment has been minimized.

Copy link
Collaborator

commented Feb 10, 2017

☀️ Test successful - zcash

@zkbot zkbot merged commit b8eb377 into zcash:master Feb 10, 2017

1 check passed

homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.