Closes #2092. Maintain record of alerts sent onto mainnet. #2093
Conversation
bitcartel
added
A-networking
| alert.strComment = ""; | ||
| alert.strStatusBar = "URGENT: Upgrade required: see https://z.cash"; | ||
| alert.strRPCError = "URGENT: Upgrade required: see https://z.cash"; | ||
| alert.strStatusBar = "Your client is out of date and potentially vulnerable to denial of service. Please update to the most recent version of Zcash (1.0.5). More info at: https://z.cash/support/security.html"; |
There was a problem hiding this comment.
should be "1.0.6", maybe "1.0.7", why not using zcash VERSION already defined to keep it dynamic!!
There was a problem hiding this comment.
Because this is documenting the message that was actually sent. There would be no point in making it dependent on the version of zcash that is sending the message, because that is only evaluated once, and then the alert message is just a string.
|
|
||
| // Set specific client version/versions here. If setSubVer is empty, no filtering on subver is done: | ||
| // alert.setSubVer.insert(std::string("/MagicBean:0.7.2/")); | ||
| alert.setSubVer.insert(std::string("/MagicBean:1.0.3/")); |
There was a problem hiding this comment.
This also needs to be refactored "/MagicBean:1.0.3/", not in this PR but in whole tree, this have to get defined somewhere, to keep code clean and can be changed in a single file
There was a problem hiding this comment.
In this case the alert was intended to only apply to 1.0.3.
There was a problem hiding this comment.
@Maroc-OS This PR is more about keeping a historical record of alerts that have been sent out.
There was a problem hiding this comment.
I C am still reading the codes, am getting it bit by bit :)
src/sendalert.cpp
Outdated
| // Sanity check | ||
| assert(alert.strComment.length() <= 65536); // max length in alert.h | ||
| assert(alert.strStatusBar.length() <= 256); | ||
| assert(alert.strRPCError.length() <= 256); |
There was a problem hiding this comment.
It looks like there's an indentation mismatch (tabs?) in this block.
There was a problem hiding this comment.
Fixed. Tabs changed to spaces.
bitcartel
force-pushed
the
sent_network_alerts
branch
from
c9fb7a1
to
f47269c
Compare
|
utReACK. @zkbot r+ |
|
📌 Commit f47269c has been approved by |
|
⌛ Testing commit f47269c with merge 55ac53a... |
|
💔 Test failed - zcash |
|
Test failures caused by #2112. |
|
@zkbot retry |
Closes #2092. Maintain record of alerts sent onto mainnet.
|
☀️ Test successful - zcash |
No description provided.