Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #2092. Maintain record of alerts sent onto mainnet. #2093

Merged
merged 3 commits into from
Feb 20, 2017
Merged

Closes #2092. Maintain record of alerts sent onto mainnet. #2093

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
684ae2a
Alert 1000
bitcartel Feb 8, 2017
4b7f603
Alert 1001
bitcartel Feb 8, 2017
f47269c
Add assert to check alert message length is valid
bitcartel Feb 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions src/sendalert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ void ThreadSendAlert()
//
CAlert alert;
alert.nRelayUntil = GetTime() + 15 * 60;
alert.nExpiration = GetTime() + 365 * 60 * 60;
alert.nID = 1000; // use https://github.com/zcash/zcash/wiki/specification#assigned-numbers to keep track of alert IDs
alert.nExpiration = GetTime() + 90 * 24 * 60 * 60;
alert.nID = 1001; // use https://github.com/zcash/zcash/wiki/specification#assigned-numbers to keep track of alert IDs
alert.nCancel = 0; // cancels previous messages up to this ID number

// These versions are protocol versions
Expand All @@ -86,13 +86,19 @@ void ThreadSendAlert()
// 2000 for longer invalid proof-of-work chain
// Higher numbers mean higher priority
// 4000 or higher will put the RPC into safe mode
alert.nPriority = 5000;
alert.nPriority = 1500;
alert.strComment = "";
alert.strStatusBar = "URGENT: Upgrade required: see https://z.cash";
alert.strRPCError = "URGENT: Upgrade required: see https://z.cash";
alert.strStatusBar = "Your client is out of date and potentially vulnerable to denial of service. Please update to the most recent version of Zcash (1.0.5). More info at: https://z.cash/support/security.html";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be "1.0.6", maybe "1.0.7", why not using zcash VERSION already defined to keep it dynamic!!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this is documenting the message that was actually sent. There would be no point in making it dependent on the version of zcash that is sending the message, because that is only evaluated once, and then the alert message is just a string.

alert.strRPCError = "Your client is out of date and potentially vulnerable to denial of service. Please update to the most recent version of Zcash (1.0.5). More info at: https://z.cash/support/security.html";

// Set specific client version/versions here. If setSubVer is empty, no filtering on subver is done:
// alert.setSubVer.insert(std::string("/MagicBean:0.7.2/"));
alert.setSubVer.insert(std::string("/MagicBean:1.0.3/"));
Copy link

@Maroc-OS Maroc-OS Feb 13, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be refactored "/MagicBean:1.0.3/", not in this PR but in whole tree, this have to get defined somewhere, to keep code clean and can be changed in a single file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case the alert was intended to only apply to 1.0.3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Maroc-OS This PR is more about keeping a historical record of alerts that have been sent out.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I C am still reading the codes, am getting it bit by bit :)


// Sanity check
assert(alert.strComment.length() <= 65536); // max length in alert.h
assert(alert.strStatusBar.length() <= 256);
assert(alert.strRPCError.length() <= 256);

// Sign
const CChainParams& chainparams = Params();
Expand Down