option to disable building libraries (zcutil/build.sh) #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 My nightly build has at least a thousand |
|
@aayanl That's not what this patch does; it only affects building output libraries, not dependencies. utACK. @zkbot try |
zkbot
added a commit
that referenced
this pull request
Jun 9, 2017
option to disable building libraries (zcutil/build.sh) option to disable building libraries (zcutil/build.sh)
daira
approved these changes
Jun 9, 2017
|
☀️ Test successful - pr-try |
|
Needs another ACK + smoke-testing the case where the option is set. |
|
Note that this is just exposing an existing option in the Makefiles via build.sh. |
str4d
approved these changes
Jun 14, 2017
There was a problem hiding this comment.
utACK. I'm personally against adding yet more flags to build.sh; I'd prefer the approach I take in #2120 where we use an environment variable for configure flags vs. program arguments for make. But for now I'm happy to enable better use cases for building.
|
@zkbot r+ |
|
📌 Commit c63417b has been approved by |
zkbot
added a commit
that referenced
this pull request
Jun 15, 2017
option to disable building libraries (zcutil/build.sh) option to disable building libraries (zcutil/build.sh)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
option to disable building libraries (zcutil/build.sh)