Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Test] New merge test suite driver script #2654

Merged
merged 5 commits into from
Oct 17, 2017
Merged

[Test] New merge test suite driver script #2654

merged 5 commits into from
Oct 17, 2017

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Oct 6, 2017

Running the script with no arguments will run all test stages in succession.
Passing one or more stages as arguments will run just those stages.

Closes #429.

@str4d str4d added the A-testing Area: Tests and testing infrastructure label Oct 6, 2017
@str4d str4d added this to the 1.0.13 CI release milestone Oct 6, 2017
daira
daira approved these changes Oct 9, 2017
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@str4d
Add bitcoin-util-test.py to full_test_suite.py
88fbdc4 
Not moved, because upstream makes improvements to this script, and the need to
set environment variables makes it simpler to just use the given script.
@str4d
Add stdout notice if any stage fails
6e98511
@arielgabizon
Copy link
Contributor

Do you need to remove the call to bitcoin-util-test.py in Makefile, since you're now running it from here?

@str4d
Copy link
Contributor Author

str4d commented Oct 17, 2017

I'm fine leaving it in make check for now, as that includes a bunch of other things too. If we do decide to alter that, we should just have it point to this script; doing so will require delving into the Makefile, which is out of scope for this issue.

@str4d
Copy link
Contributor Author

str4d commented Oct 17, 2017

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Oct 17, 2017

📌 Commit 6e98511 has been approved by str4d

@zkbot
Copy link
Contributor

zkbot commented Oct 17, 2017

⌛ Testing commit 6e98511 with merge 6870c17ceb801535d82e9097cbbbddb824670fbe...

@zkbot
Copy link
Contributor

zkbot commented Oct 17, 2017

💔 Test failed - pr-merge

@str4d
Copy link
Contributor Author

str4d commented Oct 17, 2017

Cancelled in order to fix a CI config issue.

@zkbot retry

@zkbot
Copy link
Contributor

zkbot commented Oct 17, 2017

⌛ Testing commit 6e98511 with merge 4c9b77d...

zkbot added a commit that referenced this pull request Oct 17, 2017
@zkbot
Auto merge of #2654 - str4d:429-test-driver-script, r=str4d
4c9b77d 
[Test] New merge test suite driver script

Running the script with no arguments will run all test stages in succession.
Passing one or more stages as arguments will run just those stages.

Closes #429.
@zkbot
Copy link
Contributor

zkbot commented Oct 17, 2017

☀️ Test successful - pr-merge
Approved by: str4d
Pushing 4c9b77d to master...

@zkbot zkbot merged commit 6e98511 into zcash:master Oct 17, 2017
@str4d str4d deleted the 429-test-driver-script branch October 17, 2017 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@arielgabizon arielgabizon arielgabizon approved these changes

@nathan-at-least nathan-at-least Awaiting requested review from nathan-at-least

@arcalinea arcalinea Awaiting requested review from arcalinea

Assignees
No one assigned
Labels
A-testing Area: Tests and testing infrastructure
Projects
None yet
Milestone
1.0.13 CI release
Development

Successfully merging this pull request may close these issues.
4 participants
@str4d @arielgabizon @zkbot @daira