Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now redundant Rust call to librustzcash_xor. #3321

Merged
merged 1 commit into from
Jun 8, 2018

Conversation

bitcartel
Copy link
Contributor

@bitcartel bitcartel commented Jun 5, 2018

Related to zcash/librustzcash#17 which removes librustzcash_xor from library.

@bitcartel bitcartel added the C-cleanup Category: PRs that clean code up or issues documenting cleanup. label Jun 5, 2018
@bitcartel bitcartel self-assigned this Jun 5, 2018
@bitcartel bitcartel requested review from ebfull and str4d June 5, 2018 18:59
@bitcartel bitcartel changed the title [WIP - need to update with librustzcash commit id] Remove now redundant Rust call to librustzcash_xor. Remove now redundant Rust call to librustzcash_xor. Jun 7, 2018
@zcash zcash deleted a comment from zkbot Jun 7, 2018
@bitcartel bitcartel added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2018
@bitcartel bitcartel requested a review from mdr0id June 7, 2018 06:25
Copy link
Contributor

@mdr0id mdr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@str4d
Copy link
Contributor

str4d commented Jun 8, 2018

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Jun 8, 2018

📌 Commit 10a7d55 has been approved by str4d

@zkbot
Copy link
Contributor

zkbot commented Jun 8, 2018

⌛ Testing commit 10a7d55 with merge de1bc2d...

zkbot added a commit that referenced this pull request Jun 8, 2018
Remove now redundant Rust call to librustzcash_xor.

Related to zcash/librustzcash#17 which removes librustzcash_xor from library.
@str4d str4d added this to the v2.0.0 milestone Jun 8, 2018
@zkbot
Copy link
Contributor

zkbot commented Jun 8, 2018

☀️ Test successful - pr-merge
Approved by: str4d
Pushing de1bc2d to master...

@zkbot zkbot merged commit 10a7d55 into zcash:master Jun 8, 2018
@daira
Copy link
Contributor

daira commented Jun 9, 2018

Post-hoc ACK (with zcash/librustzcash#17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: PRs that clean code up or issues documenting cleanup. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants