New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now redundant Rust call to librustzcash_xor. #3321

Merged
merged 1 commit into from Jun 8, 2018

Conversation

@bitcartel
Copy link
Contributor

bitcartel commented Jun 5, 2018

Related to zcash/librustzcash#17 which removes librustzcash_xor from library.

@bitcartel bitcartel added the cleanup label Jun 5, 2018

@bitcartel bitcartel self-assigned this Jun 5, 2018

@bitcartel bitcartel requested review from ebfull and str4d Jun 5, 2018

@bitcartel bitcartel added this to In Progress in Zcashd Team Jun 6, 2018

@bitcartel bitcartel force-pushed the bitcartel:remove_librustcash_xor branch from 5ea3906 to 285acf6 Jun 7, 2018

@bitcartel bitcartel changed the title [WIP - need to update with librustzcash commit id] Remove now redundant Rust call to librustzcash_xor. Remove now redundant Rust call to librustzcash_xor. Jun 7, 2018

@bitcartel bitcartel force-pushed the bitcartel:remove_librustcash_xor branch from 285acf6 to 10a7d55 Jun 7, 2018

@zcash zcash deleted a comment from zkbot Jun 7, 2018

@bitcartel bitcartel requested a review from mdr0id Jun 7, 2018

@bitcartel bitcartel moved this from In Progress to In Review in Zcashd Team Jun 7, 2018

@mdr0id

mdr0id approved these changes Jun 7, 2018

Copy link
Contributor

mdr0id left a comment

ACK

@str4d

str4d approved these changes Jun 8, 2018

Copy link
Contributor

str4d left a comment

ACK

@str4d

This comment has been minimized.

Copy link
Contributor

str4d commented Jun 8, 2018

@zkbot r+

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 8, 2018

📌 Commit 10a7d55 has been approved by str4d

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 8, 2018

⌛️ Testing commit 10a7d55 with merge de1bc2d...

zkbot added a commit that referenced this pull request Jun 8, 2018

Auto merge of #3321 - bitcartel:remove_librustcash_xor, r=str4d
Remove now redundant Rust call to librustzcash_xor.

Related to zcash/librustzcash#17 which removes librustzcash_xor from library.

@str4d str4d added this to the v2.0.0 milestone Jun 8, 2018

@zkbot

This comment has been minimized.

Copy link
Collaborator

zkbot commented Jun 8, 2018

☀️ Test successful - pr-merge
Approved by: str4d
Pushing de1bc2d to master...

@zkbot zkbot merged commit 10a7d55 into zcash:master Jun 8, 2018

1 check passed

homu Test successful
Details

Zcashd Team automation moved this from In Review to Released (Merged in Master) Jun 8, 2018

@daira

This comment has been minimized.

Copy link
Contributor

daira commented Jun 9, 2018

Post-hoc ACK (with zcash/librustzcash#17)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment