-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove now redundant Rust call to librustzcash_xor. #3321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitcartel
added
the
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
label
Jun 5, 2018
bitcartel
force-pushed
the
remove_librustcash_xor
branch
from
June 7, 2018 06:23
5ea3906
to
285acf6
Compare
bitcartel
changed the title
[WIP - need to update with librustzcash commit id] Remove now redundant Rust call to librustzcash_xor.
Remove now redundant Rust call to librustzcash_xor.
Jun 7, 2018
bitcartel
force-pushed
the
remove_librustcash_xor
branch
from
June 7, 2018 06:24
285acf6
to
10a7d55
Compare
bitcartel
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jun 7, 2018
mdr0id
approved these changes
Jun 7, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
str4d
approved these changes
Jun 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
@zkbot r+ |
📌 Commit 10a7d55 has been approved by |
zkbot
added a commit
that referenced
this pull request
Jun 8, 2018
Remove now redundant Rust call to librustzcash_xor. Related to zcash/librustzcash#17 which removes librustzcash_xor from library.
Post-hoc ACK (with zcash/librustzcash#17) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C-cleanup
Category: PRs that clean code up or issues documenting cleanup.
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to zcash/librustzcash#17 which removes librustzcash_xor from library.