Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
TransactionBuilder for Sapling and transparent transactions #3417
referenced this pull request
Jul 26, 2018
I'd like to see this merged together with a PR to use a version of sapling-crypto that includes zcash-hackworks/sapling-crypto#80 , so that we don't inadvertently end up with two chain splits. The rationale is that this rule change will create a split on the next Sapling transaction, whereas the RedDSA change will only do so if someone creates a nonstandard signature (that will never be created by an unmodified zcashd).
Overall looks good.
One general comment that I have is that it would be nice if the methods in TransactionBuilder returned *this rather than bool or void. Because this is not yet used in production it is hard to tell if this makes TransactionBuilder easier to use. Returning a bool is useful if we are able to write code to recover from whatever has caused the failure. If we are not able to recover, we may as well throw some error rather than return bool as this can include more information. Similarly, are we able to recover if .Build() returns none? Would we be able to provide the end user more information if we throw an error in .Build() rather than returning none?
added a commit
this pull request
Jul 31, 2018
Tests fail when running locally