Add dev fund addresses for mainnet #4700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
approved these changes
Aug 31, 2020
There was a problem hiding this comment.
utACK abd4b73. I checked the following:
- That there are 48 ECC, 1 ZF, and 1 MG address strings that are correctly encoded, unique, transparent P2SH addresses.
- That there are the correct number of addresses for each funding stream (48).
- That the funding stream end heights are correct.
My understanding is that the actual addresses will be checked independently.
|
@zkbot r+ |
|
📌 Commit abd4b73 has been approved by |
|
⌛ Testing commit abd4b73 with merge 72253fba86ca30a4383d369b01a428786d88cd92... |
dconnolly
reviewed
Aug 31, 2020
nuttycom
approved these changes
Aug 31, 2020
|
💥 Test timed out |
daira
reviewed
Sep 1, 2020
|
@zkbot r+ |
|
📌 Commit 889b05d has been approved by |
r3ld3v
approved these changes
Sep 1, 2020
r3ld3v
reviewed
Sep 1, 2020
|
💔 Test failed - pr-merge |
dconnolly
approved these changes
Sep 1, 2020
daira
added a commit
to daira/zips
that referenced
this pull request
Oct 27, 2020
These were added to zcashd in zcash/zcash#4700 . Also rename the funding stream from FS_ZIP214_ECC to FS_ZIP214_BP (see zcash/zcash#4830), and "ECC slice" to "BP slice". Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.