-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dev fund addresses for mainnet #4700
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK abd4b73. I checked the following:
- That there are 48 ECC, 1 ZF, and 1 MG address strings that are correctly encoded, unique, transparent P2SH addresses.
- That there are the correct number of addresses for each funding stream (48).
- That the funding stream end heights are correct.
My understanding is that the actual addresses will be checked independently.
@zkbot r+ |
📌 Commit abd4b73 has been approved by |
⌛ Testing commit abd4b73 with merge 72253fba86ca30a4383d369b01a428786d88cd92... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. Verified end height of 2726400.
💥 Test timed out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK.
@zkbot r+ |
📌 Commit 889b05d has been approved by |
💔 Test failed - pr-merge |
These were added to zcashd in zcash/zcash#4700 . Also rename the funding stream from FS_ZIP214_ECC to FS_ZIP214_BP (see zcash/zcash#4830), and "ECC slice" to "BP slice". Signed-off-by: Daira Hopwood <daira@jacaranda.org>
No description provided.