Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Orchard commitment tree hashes to use total MerkleCRH^Orchard. #5246

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Update Orchard commitment tree hashes to use total MerkleCRH^Orchard. #5246

merged 2 commits into from
Jul 9, 2021

Conversation

nuttycom
Copy link
Contributor

@nuttycom nuttycom commented Jul 1, 2021

@nuttycom nuttycom requested review from daira and str4d July 1, 2021 18:19
@nuttycom nuttycom added this to the Core Sprint 2021-24 milestone Jul 1, 2021
@r3ld3v r3ld3v added the S-committed Status: Planned work in a sprint label Jul 6, 2021
daira
daira reviewed Jul 8, 2021
View reviewed changes
Cargo.lock Outdated Show resolved Hide resolved
daira
daira approved these changes Jul 8, 2021
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

str4d
str4d approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@str4d str4d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK after dependency update.

Cargo.toml Outdated Show resolved Hide resolved
src/rust/src/orchard_ffi/incremental_sinsemilla_tree_ffi.rs Outdated Show resolved Hide resolved
src/rust/src/orchard_ffi/incremental_sinsemilla_tree_ffi.rs Outdated Show resolved Hide resolved
src/rust/src/orchard_ffi/incremental_sinsemilla_tree_ffi.rs Outdated Show resolved Hide resolved
@nuttycom nuttycom force-pushed the consensus/total_orchard_merklecrh branch from d76311e to 780caf3 Compare July 9, 2021 14:15
@nuttycom nuttycom force-pushed the consensus/total_orchard_merklecrh branch from 21025ee to e588d1d Compare July 9, 2021 16:41
daira
daira approved these changes Jul 9, 2021
View reviewed changes
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom
Copy link
Contributor Author

nuttycom commented Jul 9, 2021

@zkbot r+

@zkbot
Copy link
Contributor

zkbot commented Jul 9, 2021

📌 Commit a484713 has been approved by nuttycom

@zkbot
Copy link
Contributor

zkbot commented Jul 9, 2021

⌛ Testing commit a484713 with merge 15041a3...

@zkbot
Copy link
Contributor

zkbot commented Jul 9, 2021

☀️ Test successful - pr-merge
Approved by: nuttycom
Pushing 15041a3 to master...

@zkbot zkbot merged commit 15041a3 into zcash:master Jul 9, 2021
@str4d str4d mentioned this pull request Jul 19, 2021
Closed
5 tasks
@nuttycom nuttycom deleted the consensus/total_orchard_merklecrh branch August 13, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

@str4d str4d str4d approved these changes

Assignees
No one assigned
Labels
S-committed Status: Planned work in a sprint
Projects
None yet
Milestone
Core Sprint 2021-26
Development

Successfully merging this pull request may close these issues.
5 participants
@nuttycom @zkbot @daira @str4d @r3ld3v