-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ed25519-zebra dependency to 4.x #6705
Conversation
This deduplicates sha2, rand-core, block-buffer, digest, and ahash. (It adds duplications for hashbrown and libm which are less important.) Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
@@ -1382,6 +1391,16 @@ version = "0.1.1" | |||
source = "registry+https://github.com/rust-lang/crates.io-index" | |||
checksum = "b15813163c1d831bf4a13c3610c05c0d03b39feb07f7e09fa234dac9b15aaf39" | |||
|
|||
[[package]] | |||
name = "packed_simd_2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't be confused by the README on crates.io, as I nearly was. packed_simd
is the unmaintained version; packed_simd_2
is the (somewhat) maintained one. dalek-cryptography/curve25519-dalek#520, which has been merged but not released, will remove this dependency. So, we won't be relying on it long-term (and that will also get rid of the libm 0.1.4
dependency, deduplicating libm
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
This PR's commit was rolled back from the release branch, as we weren't going to cut another RC. So this will need to be re-opened against |
Reopened as #6708. The branch should probably be rebased, or it can wait to merge until after the release. |
This deduplicates sha2, rand-core, block-buffer, digest, and ahash. (It adds duplications for hashbrown and libm which are less important.) I have audited some but not all of the new dependencies.
Note that it is targeted to the version-5.6.0 branch.
fixes #6648