Update ed25519-zebra dependency to 4.x #6705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deduplicates sha2, rand-core, block-buffer, digest, and ahash. (It adds duplications for hashbrown and libm which are less important.) Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
daira
commented
Jun 9, 2023
| @@ -1382,6 +1391,16 @@ version = "0.1.1" | |||
| source = "registry+https://github.com/rust-lang/crates.io-index" | |||
| checksum = "b15813163c1d831bf4a13c3610c05c0d03b39feb07f7e09fa234dac9b15aaf39" | |||
|
|
|||
| [[package]] | |||
| name = "packed_simd_2" | |||
There was a problem hiding this comment.
Don't be confused by the README on crates.io, as I nearly was. packed_simd is the unmaintained version; packed_simd_2 is the (somewhat) maintained one. dalek-cryptography/curve25519-dalek#520, which has been merged but not released, will remove this dependency. So, we won't be relying on it long-term (and that will also get rid of the libm 0.1.4 dependency, deduplicating libm).
daira
changed the title
ebfull
approved these changes
Jun 13, 2023
|
This PR's commit was rolled back from the release branch, as we weren't going to cut another RC. So this will need to be re-opened against |
|
Reopened as #6708. The branch should probably be rebased, or it can wait to merge until after the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deduplicates sha2, rand-core, block-buffer, digest, and ahash. (It adds duplications for hashbrown and libm which are less important.) I have audited some but not all of the new dependencies.
Note that it is targeted to the version-5.6.0 branch.
fixes #6648