Implement {PartialOrd, Ord, Hash} for DiversifierIndex
#16
+32
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
force-pushed
the
diversifier_index_ord
branch
from
3619a58
to
38e39b7
Compare
daira
reviewed
Sep 11, 2024
| .iter() | ||
| .rev() | ||
| .zip(other.0.iter().rev()) | ||
| .find_map(|(a, b)| match a.cmp(b) { |
There was a problem hiding this comment.
Doesn't a [u8] already have an ordering? I.e. it should be possible to compare the reversed arrays directly.
There was a problem hiding this comment.
This uses the reversed iterators, and so doesn't require allocation of a Vec in order to compare the slices.
daira
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.