Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review of protocol spec #10

Closed
ebfull opened this issue Feb 17, 2016 · 2 comments
Closed

Review of protocol spec #10

ebfull opened this issue Feb 17, 2016 · 2 comments

Comments

@ebfull
Copy link
Contributor

ebfull commented Feb 17, 2016

  1. In 2.2, Nathan's note could mention that output arity also affects the design there, due to PRFρ.
  2. In 2.4.1, the text "Any ciphertext components that fail to decrypt with a given recipient's private key will be ignored" needs to be clarified with who, what and why.
  3. In 2.4.2, "InternalH" needs a better name. I originally called it this probably as a placeholder. Does the zerocash paper not have a name for it?
  4. In 2.7 our description of anchors can be simplified. "A pour description's anchor may reference an earlier block's treestate or the treestate of an earlier pour description." We could also clarify "The treestates of pour descriptions are their anchored trees appended with their commitments" or something, so people know what we mean by their treestates.
  5. In 4.5 the text regarding s should be in magenta, and we should also be clear that we differ from zerocash in this respect because we can: a naked commitment is perfectly fine there.

Feel free to close this once you've considered or fixed everything in this ticket.

@daira daira self-assigned this Feb 17, 2016
@daira
Copy link
Collaborator

daira commented Feb 17, 2016

+1 for comments 1-4.

Re: 5, the text about s also applies to the protocol in the paper; it is not a change.

@daira
Copy link
Collaborator

daira commented Feb 27, 2016

All considered or fixed.

@daira daira closed this as completed Feb 27, 2016
daira added a commit to daira/zips that referenced this issue Nov 8, 2023
Co-authored-by: daniben31 <danielbenarroch92@gmail.com>
Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Jonathan S. Rouach <jon@rouach.net>
Co-authored-by: str4d <thestr4d@gmail.com>
Co-authored-by: Paul <lauxpaul@protonmail.com>
daira added a commit to daira/zips that referenced this issue Feb 7, 2024
Co-authored-by: daniben31 <danielbenarroch92@gmail.com>
Co-authored-by: Deirdre Connolly <durumcrustulum@gmail.com>
Co-authored-by: Daira-Emma Hopwood <daira@jacaranda.org>
Co-authored-by: Jonathan S. Rouach <jon@rouach.net>
Co-authored-by: str4d <thestr4d@gmail.com>
Co-authored-by: Paul <lauxpaul@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants