Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Updates ZIP 243] Update test vectors to match generator output #208

Merged
merged 1 commit into from Jun 5, 2019
Merged

[Updates ZIP 243] Update test vectors to match generator output #208

merged 1 commit into from Jun 5, 2019

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Feb 22, 2019

Correct as of zcash-test-vectors commit 38cdeda51c0bf1d4714fc3a0b955b519c0373c20

@str4d
ZIP 243: Update test vectors to match generator output
0f32bd8 
Correct as of zcash-test-vectors commit 38cdeda51c0bf1d4714fc3a0b955b519c0373c20
daira
daira approved these changes Feb 23, 2019
View reviewed changes
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not verified that the test vectors are correct, but I've scanned the changes and verified that it is just replacing some test vectors with others, without changing anything else in the ZIP.

@daira daira changed the title ZIP 243: Update test vectors to match generator output [ZIP 243] Update test vectors to match generator output Mar 29, 2019
@daira daira changed the title [ZIP 243] Update test vectors to match generator output [Updates ZIP 243] Update test vectors to match generator output Apr 1, 2019
@daira
Copy link
Collaborator

daira commented Apr 2, 2019

@str4d, does this subsume #162?

@daira daira assigned daira and str4d May 28, 2019
@str4d
Copy link
Contributor Author

str4d commented Jun 5, 2019

No, that is updating ZIP 143. This is updating ZIP 243.

@str4d str4d removed the request for review from bitcartel June 5, 2019 13:11
@str4d str4d merged commit 591ffa6 into zcash:master Jun 5, 2019
@str4d str4d deleted the zip-243-updates branch June 5, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daira daira daira approved these changes

Assignees

@daira daira

@str4d str4d

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@str4d @daira