Skip to content

Add ZIP 1014, based on ZIP 1012 with modifications from the Zcash Foundation board#308

Closed
acityinohio wants to merge 60 commits intozcash:masterfrom
ZcashFoundation:master
Closed

Add ZIP 1014, based on ZIP 1012 with modifications from the Zcash Foundation board#308
acityinohio wants to merge 60 commits intozcash:masterfrom
ZcashFoundation:master

Conversation

@acityinohio
Copy link
Copy Markdown
Contributor

Opening this PR for discussion/comments from ECC and the community.

@tromer
Copy link
Copy Markdown
Contributor

tromer commented Dec 12, 2019

utACK

I support these revisions, and in particular making the Major Grant Review Committee autonomous and binding, and the improved Funding Target update mechanism.

Copy link
Copy Markdown
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial suggestions.

@@ -3,17 +3,21 @@
ZIP: 1012
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(wearing ZIP Editor hat) I believe that this should be published as a new ZIP since it has substantive changes from ZIP 1012, and it's necessary to preserve the historical record of ZIP 1012 as voted on.

For the time being, the PR can continue to update ZIP 1012 for ease of seeing the changes, but I will change it to ZIP 1014 before publication, unless anyone raises an objection.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we publish earlier and move to ZIP 1014 @daira @gtank ? @zookozcash and I think for polling it would be nicer for folks to see it on https://zips.z.cash/ . I'd be happy to accept all these changes and get it ready to make it an easier PR.

Copy link
Copy Markdown
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that my "Approve" review indicates only ZIP Editor approval to publish as ZIP 1014, and is not an indication of approval to the content by ECC. ECC had published its response here: https://electriccoin.co/blog/dev-funds-should-be-in-zcash-not-united-states-dollars/

acityinohio and others added 13 commits December 20, 2019 12:55
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Addresses a FAQ on how Volatility Reserve is meant to work. No normative changes.
ZIP 1014 Volatility Reserve clarifications
Copy link
Copy Markdown
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with suggestions (mainly RFC 2119 conformance language).

Copy link
Copy Markdown
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK with suggestions (mainly RFC 2119 conformance language).

@daira daira changed the title Updates ZIP 1012 to include modifications from the Zcash Foundation board Add ZIP 1014, based on ZIP 1012 with modifications from the Zcash Foundation board Dec 27, 2019
@daira
Copy link
Copy Markdown
Collaborator

daira commented Dec 28, 2019

(Speaking for myself.) I made a couple of comments on the forum regarding the status of ECC in applying for Major Grants: https://forum.zcashcommunity.com/t/community-sentiment-polling-results-nu4/35560/223

tromer and others added 5 commits December 28, 2019 21:27
Clarify language around the criteria for awarding major grants.
No normative changes intended, other than removal of "new" in
item 4, which conflicts with the "maintain the existing teams
and capabilities" goal of this ZIP.
ZIP 1014: fix typo ("voting mechanism")
@tromer
Copy link
Copy Markdown
Contributor

tromer commented Jan 7, 2020

Regarding the RFC 2119 changes ("SHALL", etc.): Is there a consensus among the ZIP editors that these changes are desirable? If so, I'll review them and submit a pull request.

I very mildly prefer to not make the change to RFC 2119 language, because they make it more difficult to see the differences from ZIP 1012, and because to me it feels awkward to use this formal language for terms that (by necessity) fuzzy.

acityinohio and others added 26 commits January 7, 2020 09:33
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
@acityinohio
Copy link
Copy Markdown
Contributor Author

@daira I made what should be the final fixes, and out-of-band @tromer agreed that we can find another place to show the substantive diff without modifying ZIP 1012 (for historical preservation reasons). @gtank does it look good to you?

@daira
Copy link
Copy Markdown
Collaborator

daira commented Jan 7, 2020

Superceded by #312.

@daira daira closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants