Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZIP 1014, based on ZIP 1012 with modifications from the Zcash Foundation board #308

Closed
wants to merge 60 commits into from
Closed

Conversation

acityinohio
Copy link
Contributor

@acityinohio acityinohio commented Dec 12, 2019

Opening this PR for discussion/comments from ECC and the community.

@tromer
Copy link
Contributor

@tromer tromer commented Dec 12, 2019

utACK

I support these revisions, and in particular making the Major Grant Review Committee autonomous and binding, and the improved Funding Target update mechanism.

zip-1012.rst Outdated Show resolved Hide resolved
daira
daira approved these changes Dec 19, 2019
Copy link
Collaborator

@daira daira left a comment

Editorial suggestions.

zip-1012.rst Outdated Show resolved Hide resolved
zip-1012.rst Outdated Show resolved Hide resolved
zip-1012.rst Outdated Show resolved Hide resolved
zip-1012.rst Outdated
@@ -3,17 +3,21 @@
ZIP: 1012
Copy link
Collaborator

@daira daira Dec 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(wearing ZIP Editor hat) I believe that this should be published as a new ZIP since it has substantive changes from ZIP 1012, and it's necessary to preserve the historical record of ZIP 1012 as voted on.

For the time being, the PR can continue to update ZIP 1012 for ease of seeing the changes, but I will change it to ZIP 1014 before publication, unless anyone raises an objection.

Copy link
Contributor Author

@acityinohio acityinohio Dec 20, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we publish earlier and move to ZIP 1014 @daira @gtank ? @zookozcash and I think for polling it would be nicer for folks to see it on https://zips.z.cash/ . I'd be happy to accept all these changes and get it ready to make it an easier PR.

zip-1012.rst Outdated Show resolved Hide resolved
zip-1012.rst Outdated Show resolved Hide resolved
zip-1012.rst Outdated Show resolved Hide resolved
zip-1012.rst Outdated Show resolved Hide resolved
zip-1012.rst Outdated Show resolved Hide resolved
zip-1012.rst Outdated Show resolved Hide resolved
Copy link
Collaborator

@daira daira left a comment

Note that my "Approve" review indicates only ZIP Editor approval to publish as ZIP 1014, and is not an indication of approval to the content by ECC. ECC had published its response here: https://electriccoin.co/blog/dev-funds-should-be-in-zcash-not-united-states-dollars/

acityinohio and others added 13 commits Dec 20, 2019
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Addresses a FAQ on how Volatility Reserve is meant to work. No normative changes.
ZIP 1014 Volatility Reserve clarifications
daira
daira approved these changes Dec 27, 2019
Copy link
Collaborator

@daira daira left a comment

ACK with suggestions (mainly RFC 2119 conformance language).

zip-1014.rst Outdated Show resolved Hide resolved
zip-1014.rst Outdated Show resolved Hide resolved
zip-1014.rst Outdated Show resolved Hide resolved
zip-1014.rst Outdated Show resolved Hide resolved
zip-1014.rst Outdated Show resolved Hide resolved
zip-1014.rst Outdated Show resolved Hide resolved
zip-1014.rst Outdated Show resolved Hide resolved
zip-1014.rst Outdated Show resolved Hide resolved
zip-1014.rst Outdated Show resolved Hide resolved
zip-1014.rst Outdated Show resolved Hide resolved
daira
daira approved these changes Dec 27, 2019
Copy link
Collaborator

@daira daira left a comment

ACK with suggestions (mainly RFC 2119 conformance language).

@daira daira changed the title Updates ZIP 1012 to include modifications from the Zcash Foundation board Add ZIP 1014, based on ZIP 1012 with modifications from the Zcash Foundation board Dec 27, 2019
@daira
Copy link
Collaborator

@daira daira commented Dec 28, 2019

(Speaking for myself.) I made a couple of comments on the forum regarding the status of ECC in applying for Major Grants: https://forum.zcashcommunity.com/t/community-sentiment-polling-results-nu4/35560/223

zip-1014.rst Outdated Show resolved Hide resolved
tromer and others added 5 commits Dec 29, 2019
Clarify language around the criteria for awarding major grants.
No normative changes intended, other than removal of "new" in
item 4, which conflicts with the "maintain the existing teams
and capabilities" goal of this ZIP.
ZIP 1014: fix typo ("voting mechanism")
zip-1014.rst Outdated Show resolved Hide resolved
@tromer
Copy link
Contributor

@tromer tromer commented Jan 7, 2020

Regarding the RFC 2119 changes ("SHALL", etc.): Is there a consensus among the ZIP editors that these changes are desirable? If so, I'll review them and submit a pull request.

I very mildly prefer to not make the change to RFC 2119 language, because they make it more difficult to see the differences from ZIP 1012, and because to me it feels awkward to use this formal language for terms that (by necessity) fuzzy.

acityinohio and others added 26 commits Jan 7, 2020
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
Co-Authored-By: Daira Hopwood <daira@jacaranda.org>
@acityinohio
Copy link
Contributor Author

@acityinohio acityinohio commented Jan 7, 2020

@daira I made what should be the final fixes, and out-of-band @tromer agreed that we can find another place to show the substantive diff without modifying ZIP 1012 (for historical preservation reasons). @gtank does it look good to you?

zip-1014.rst Show resolved Hide resolved
@daira
Copy link
Collaborator

@daira daira commented Jan 7, 2020

Superceded by #312.

@daira daira closed this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants