Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the specification of minimum-difficulty blocks to reflect the zcashd implementation #417

Merged
merged 4 commits into from
Nov 13, 2020

Conversation

daira
Copy link
Collaborator

@daira daira commented Nov 11, 2020

The implementation alters nBits rather than just the target threshold. fixes #416
refs ZcashFoundation/zebra#1277

Signed-off-by: Daira Hopwood daira@jacaranda.org

…zcashd implementation

(which alters nBits rather than just the target threshold). fixes #416

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@teor2345
Copy link
Contributor

This PR also documents the conversion of PoWLimit using ToCompact().
So it also closes ZcashFoundation/zebra#1277.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks so much for making these changes.

zip-0205.rst Outdated Show resolved Hide resolved
zip-0208.rst Outdated Show resolved Hide resolved
Co-authored-by: teor <teor@riseup.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Testnet min-difficulty rules are incorrectly specified
4 participants