-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZIP 252] Network Upgrade 5 #446
Conversation
And add TODOs.
And add TODOs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! :-)
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might as well add all the draft zips as proposed?
defines a new transaction version. NU5 transactions are therefore in the new | ||
v5 format specified by [#zip-0225]_. Therefore, pre-NU5 transactions are | ||
structurally invalid after NU5 activation: they can not be parsed correctly | ||
by pre-NU5 nodes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This copied text is wrong, v4 and v5 transactions are both supported after NU5.
Should we also say something about the consensus branch ID rejecting v4 transactions created before NU5 activation? (Is that correct?)
defines a new transaction version. NU5 transactions are therefore in the new | |
v5 format specified by [#zip-0225]_. Therefore, pre-NU5 transactions are | |
structurally invalid after NU5 activation: they can not be parsed correctly | |
by pre-NU5 nodes. | |
defines a new transaction version. Therefore, NU5 transactions MAY be in | |
the new v5 format specified by [#zip-0225]_. Unlike previous transaction | |
version updates, the pre-NU5 v4 transaction format remains valid after | |
NU5 activation. Both transaction formats MUST be accepted by NU5 | |
nodes. | |
v5 transactions MUST be used for: | |
- Orchard transfers | |
- non-malleable transaction IDs | |
v4 transactions MUST be used for: | |
- Sprout transfers | |
Transactions that don't need these features can use either format. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The v4 transactions MUST be used for Sprout Transfers
is a modification that we hadn't talked about before, but I think that this could be a good idea; we could entirely remove Sprout support from the V5 transaction format in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, how do we even make decisions like this? 🤷
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, how do we even make decisions like this? 🤷
I'll make sure we discuss it at the Arborist call on the 11th.
This is an initial draft of the NU 5 ZIP, based on ZIP-251 - Canopy.
Changes from Canopy
I have made the following changes:
zcashd
-specific behaviourzcashd
and ZebraRemaining Work
zcashd
sectionOptional