Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZIP 252] Network Upgrade 5 #446

Merged
merged 19 commits into from
Mar 4, 2021
Merged

[ZIP 252] Network Upgrade 5 #446

merged 19 commits into from
Mar 4, 2021

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Feb 23, 2021

This is an initial draft of the NU 5 ZIP, based on ZIP-251 - Canopy.

Changes from Canopy

I have made the following changes:

Remaining Work

  • Choose NU5 ZIPs
  • Update transaction version backward compatibility if ZIP 225 is accepted
  • Update zcashd section
  • Update Zebra section
  • Update references

Optional

  • Pick a name for NU5

@teor2345 teor2345 changed the title ZIP 252: Network Upgrade 5 - Initial Draft [ZIP 252] Network Upgrade 5 Feb 23, 2021
Copy link
Collaborator

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :-)

zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
teor2345 and others added 4 commits February 24, 2021 08:00
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Co-authored-by: Daira Hopwood <daira@jacaranda.org>
Copy link
Contributor Author

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might as well add all the draft zips as proposed?

zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Show resolved Hide resolved
@r3ld3v r3ld3v added this to the Core Sprint 2021-06 milestone Feb 26, 2021
zip-0252.rst Outdated Show resolved Hide resolved
Comment on lines +99 to +102
defines a new transaction version. NU5 transactions are therefore in the new
v5 format specified by [#zip-0225]_. Therefore, pre-NU5 transactions are
structurally invalid after NU5 activation: they can not be parsed correctly
by pre-NU5 nodes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This copied text is wrong, v4 and v5 transactions are both supported after NU5.

Should we also say something about the consensus branch ID rejecting v4 transactions created before NU5 activation? (Is that correct?)

Suggested change
defines a new transaction version. NU5 transactions are therefore in the new
v5 format specified by [#zip-0225]_. Therefore, pre-NU5 transactions are
structurally invalid after NU5 activation: they can not be parsed correctly
by pre-NU5 nodes.
defines a new transaction version. Therefore, NU5 transactions MAY be in
the new v5 format specified by [#zip-0225]_. Unlike previous transaction
version updates, the pre-NU5 v4 transaction format remains valid after
NU5 activation. Both transaction formats MUST be accepted by NU5
nodes.
v5 transactions MUST be used for:
- Orchard transfers
- non-malleable transaction IDs
v4 transactions MUST be used for:
- Sprout transfers
Transactions that don't need these features can use either format.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The v4 transactions MUST be used for Sprout Transfers is a modification that we hadn't talked about before, but I think that this could be a good idea; we could entirely remove Sprout support from the V5 transaction format in that case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, how do we even make decisions like this? 🤷

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@teor2345 I've added this as a possible alternative to ZIP 225 in #453

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, how do we even make decisions like this? 🤷

I'll make sure we discuss it at the Arborist call on the 11th.

zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Show resolved Hide resolved
zip-0252.rst Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
zip-0252.rst Outdated Show resolved Hide resolved
@daira daira marked this pull request as ready for review March 4, 2021 03:39
@daira daira merged commit 4e2e7a6 into zcash:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants