Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ZIP 239: Relay of Version 5 Transactions #516

Merged
merged 6 commits into from
Jun 3, 2021
Merged

Add ZIP 239: Relay of Version 5 Transactions #516

merged 6 commits into from
Jun 3, 2021

Conversation

daira
Copy link
Collaborator

@daira daira commented May 29, 2021 •
edited
Loading

closes #515

Signed-off-by: Daira Hopwood daira@jacaranda.org

@daira
Add ZIP 239.
16f48e7 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira requested review from nuttycom and str4d May 29, 2021 16:51
@daira daira mentioned this pull request May 29, 2021
Closed
@daira
ZIP 239: mention getdata in Motivation.
a756260 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
ZIP 239: message type -> inv type.
50e4914 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
Copy link
Collaborator Author

daira commented May 29, 2021 •
edited
Loading

As specified in [2] (ZIP 200), a node that supports a network upgrade will clear its mempool when reaching the block before that upgrade's activation block. Before this point, the node will not accept transactions into its mempool that are invalid according to the pre-upgrade consensus protocol (so, in this case, it would not accept v5 transactions). This means that a correctly functioning node will not use the MSG_TXV5 MSG_WTX inv type until it has received the block preceding the NU5 network upgrade.

I was going from memory on how this works, and now that I check ZIP 200, it's not clearly specified exactly when the mempool is cleared. @str4d, am I right about how it works in zcashd?

daira added 2 commits May 29, 2021 18:25
@daira
ZIP 252: add references to ZIP 239.
864e1ea 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
Leave it unspecified whether MSG_TXV5 is used for v6 and later transa…
1b5786e 
…ctions.

The previous wording could have been misinterpreted to require not using MSG_TXV5 for these,
and was partly redundant. Also mention in Motivation that the format of serialized
v5 transactions is not consensus-critical.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@mpguerra mpguerra mentioned this pull request Jun 1, 2021
Closed
7 tasks
@daira daira added this to the Core Sprint 2021-20 milestone Jun 1, 2021
@daira
Add definitions; terminology changes; and rename MSG_TXV5 to `MSG_W…
f15f263 
…TX`.

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira
Copy link
Collaborator Author

daira commented Jun 1, 2021 •
edited
Loading

The last commit (f15f263) reflects changes from a review with @dconnolly and @nuttycom. Re-review needed.

@daira daira requested a review from dconnolly June 1, 2021 16:03
teor2345
teor2345 reviewed Jun 2, 2021
View reviewed changes
zip-0239.rst Show resolved Hide resolved
@daira daira merged commit 43b03a7 into zcash:master Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 left review comments

@nuttycom nuttycom nuttycom approved these changes

@str4d str4d Awaiting requested review from str4d

@dconnolly dconnolly Awaiting requested review from dconnolly

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Core Sprint 2021-20
Development

Successfully merging this pull request may close these issues.

[ZIP 239] Relay of Version 5 Transactions
3 participants
@daira @nuttycom @teor2345