Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZIP 317] Proportional Transfer Fee Mechanism #631
[ZIP 317] Proportional Transfer Fee Mechanism #631
Changes from 41 commits
400eebe
b599602
1b5a6fe
d427459
f204769
4c1970f
05c3311
c8adeaa
2e76480
27f8ace
4cc0a69
9188c51
9a717d0
b8d595b
62f6aac
63bd0d9
cff9e8e
a1906ae
595443b
91b8e83
9e642a5
b19307a
050234b
937013a
2881b47
19496d3
34a82f2
f714287
69af6ea
e232e50
94d6b8a
0628577
b7eed25
93d3ce8
7516306
5ea7810
05c8b6f
e74e23f
7bbaf4a
ffa113d
e5a6d5a
902449d
bb04751
0d6c46d
cc3d133
7756016
fd23f02
e30626a
4033b7f
23fcd67
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This section will need to become a Rationale section briefly saying why we chose these parameters and this formula. When describing the earlier proposed parameters, we will need to take into account that they are not directly comparable with the specified
marginal_fee
, because they were multiplied byinputs + outputs
instead of logical actions.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider deleting some of this section, since the premise of this ZIP is that there is at least some chance that it will work to discourage transaction DoS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Describe the effect on users of wallets that are not upgraded.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These endorsements should not be assumed until a more final version of the draft is completed, as endorsements may depend on specific parameter choices. The ZIP editors should ensure that the endorsements are accurate before merging this ZIP.