[ZIP 234] Smooth Out The Block Subsidy Issuance #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
reviewed
Sep 18, 2023
There was a problem hiding this comment.
Thanks for submitting this ZIP for review.
This ZIP is currently incompatible with the ZIP in PR #703, so that will need to be resolved if you would like them both to be accepted.
Based on our previous conversations, I did my review assuming that you wanted this ZIP to define issuance based on the ZSF balance in PR #703. If that't not correct, please feel free to ignore those parts of my review, and fix the compatibility another way.
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
teor2345
reviewed
Sep 19, 2023
teor2345
reviewed
Sep 19, 2023
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
teor2345
reviewed
Sep 21, 2023
conradoplg
reviewed
Sep 27, 2023
teor2345
reviewed
Sep 27, 2023
teor2345
reviewed
Sep 27, 2023
teor2345
reviewed
Sep 27, 2023
teor2345
reviewed
Sep 27, 2023
teor2345
reviewed
Sep 27, 2023
teor2345
reviewed
Sep 27, 2023
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: teor <teor@riseup.net>
nathan-at-least
suggested changes
Oct 10, 2023
There was a problem hiding this comment.
I propose including the changes I have suggested or similar to ensure the motivation includes two key points:
- this mechanism ensures any changes to issuance rate (up or down) are gradual to avoid disruption and enable people to plan around it.
- this mechanisms supports increases in issuance rate (via ZSF deposits in other ZIP) which take effect in the immediately subsequent block subsequent blocks (while still being gradual and predictable).
Co-authored-by: Nathan Wilcox <nathan-at-least@users.noreply.github.com>
Co-authored-by: Nathan Wilcox <nathan-at-least@users.noreply.github.com>
teor2345
reviewed
Oct 12, 2023
teor2345
reviewed
Oct 12, 2023
teor2345
reviewed
Oct 15, 2023
teor2345
reviewed
Oct 15, 2023
teor2345
reviewed
Oct 25, 2023
teor2345
reviewed
Oct 25, 2023
teor2345
reviewed
Nov 8, 2023
str4d
reviewed
Nov 8, 2023
str4d
reviewed
Nov 8, 2023
str4d
reviewed
Nov 8, 2023
Comment on lines
+161
to
+164
| Halving 1 at block 1680000: | ||
| ZSF subsidies: 262523884819889 (~ 2625238.848 ZEC, 1.563 ZEC per block) | ||
| legacy subsidies: 262500000000000 (~ 2625000.000 ZEC, 1.562 ZEC per block) | ||
| difference: 23884819889 (~ 238 ZEC), ZSF/legacy: 1.0001 |
There was a problem hiding this comment.
Action item: @daira to check these.
Co-authored-by: teor <teor@riseup.net>
Co-authored-by: str4d <thestr4d@gmail.com>
str4d
reviewed
Mar 1, 2024
| @@ -0,0 +1,166 @@ | |||
| ``` | |||
| ZIP: | |||
str4d
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.