New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZIP 320: Specify alternatives for transparent-source addresses. #760
Conversation
2a9074c
to
fc57533
Compare
This provides two alternatives for how to implement transparent-source-only addresses: * A new, separate `bech32m` encoding with the `tex` human-readable part * A modification to Unified Addresses to support the transparent-source requirement.
fc57533
to
ae1e49f
Compare
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
c1af0f9
to
2e10362
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least the error in the P2PKH lead bytes for testnet is blocking.
|
||
A Unified Viewing Key MUST contain at least one shielded Item (Typecodes | ||
:math:`\mathtt{0x02}` and :math:`\mathtt{0x03}`). | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's also necessary to add "Traceable P2PKH Receiver" to the ZIP 316 priority list. You might think that (after applying the suggestion above) it's not necessary to define its priority, because for any UA that has a Traceable P2PKH Receiver, it will be the only Receiver. However, ZIP 316 defines the "preferred" ordering like this:
We say that a Receiver Type is “preferred” over another when it appears earlier in this Priority List (as potentially modified by experiments).
which means that it is not well-defined to specify that the most-preferred Receiver is used unless all Receiver types have a priority. Also, implementations will in practice give all types a priority because that's the simplest way to implement it — so it might as well be specified that way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm. So does that mean that a Traceable P2PKH Receiver has the highest priority? I think that I would prefer to mention Traceable P2PKH Receivers in the section where priorities are defined, but instead of assigning a priority clarify that the priority of a Traceable P2PKH Receiver is undefined as it must never be present in an address with any other receivers.
Sum type, rather than picking an "unused" element of the domain, you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it matters as long as the Receiver selection is well-defined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more comments.
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
d080c07
to
e11ddc4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK. This can be merged once comments are addressed.
Co-authored-by: Daira Emma Hopwood <daira@jacaranda.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post-hoc ACK.
|
||
The Binance cryptocurrency exchange requires that funds sent to their deposit | ||
addresses come from source addresses that are readily identifiable using | ||
on-chain information, such that if necessary funds may be rejected by sending |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add commas before/after "if necessary" here for clarity?
Post-hoc review, looks good |
This provides two alternatives for how to implement transparent-source-only addresses:
tex
human-readable partcloses #757