-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ZIP 320: Specify Alternative 2 in terms of a MUST-understand metadata item #766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
previously requested changes
Jan 26, 2024
nuttycom
force-pushed
the
zip_0320-ua_must_understand
branch
from
January 26, 2024 05:07
8882179
to
1019792
Compare
daira
reviewed
Feb 2, 2024
daira
reviewed
Feb 2, 2024
daira
approved these changes
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK modulo comment.
daira
reviewed
Feb 2, 2024
daira
reviewed
Feb 2, 2024
daira
force-pushed
the
zip_0320-ua_must_understand
branch
from
February 2, 2024 23:36
c6a7867
to
5769579
Compare
daira
force-pushed
the
zip_0320-ua_must_understand
branch
2 times, most recently
from
February 4, 2024 15:14
3b19000
to
f89a877
Compare
… UVKs. Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
daira
force-pushed
the
zip_0320-ua_must_understand
branch
from
February 4, 2024 15:17
f89a877
to
e2d7738
Compare
nuttycom
commented
Feb 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK e2d7738
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.