Support conversions from Map to Object (#39) #41
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting from a
Map
to anObject
seems to be substantially the same as converting from anObject
. The only difference is that converting from aMap
must be unsafe as we don’t know if it has all of the necessary keys until we try to do the conversion.I attempted to share as much of
conversionObjectToObject
as possible, then duplicated all of theObject
-to-Object
tests asMap
-to-Object
.This is my first time writing go so please let me know if I haven’t done things in the idiomatic way, or have missed some potential pitfall.
Fixes #39.