Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert: Fix MismatchMessage for object attributes #78

Commits on Nov 23, 2020

  1. convert: Fix MismatchMessage for object attributes

    When determining which object attributes cause a type mismatch, we must
    disregard equal attribute types. Previously we would attempt to find a
    conversion between them, deciding that the attribute type was a mismatch
    if no conversion exists. However, this is invalid if the two types are
    equal, because GetConversion returns nil for equal primitive types.
    
    Because of non-deterministic map iteration order, the test case added in
    this commit failed approximately 2/3 of the time before the change. It
    now passes consistently.
    alisdair committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    0d0da20 View commit details
    Browse the repository at this point in the history