Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 1.9.2 / RubyGems 1.8.5 compatibility fix (pass String instead of Pathname to require) #26

Merged
merged 1 commit into from
Jun 23, 2011

Conversation

fallwith
Copy link
Contributor

We need this small fix (cast Pathname objects to String prior to sending them to 'require') for compatibility with Ruby 1.9.2 / RubyGems 1.8.5.

/Users/fallwith/.rvm/rubies/ruby-1.9.2-head/lib/ruby/site_ruby/1.9.1/rubygems.rb:971:in `escape': can't convert Pathname to String (TypeError)
from /Users/fallwith/.rvm/rubies/ruby-1.9.2-head/lib/ruby/site_ruby/1.9.1/rubygems.rb:971:in `block in loaded_path?'

Regexp.escape which is called by Gem.loaded_path? (/usr/local/lib/ruby/site_ruby/1.9.1/rubygems.rb) expects the path as a String, not a Pathname. Convert Pathnames to Strings prior to calling 'require'

…y/site_ruby/1.9.1/rubygems.rb) expects the path as a String, not a Pathname. Convert Pathnames to Strings prior to calling 'require'
zdennis added a commit that referenced this pull request Jun 23, 2011
Ruby 1.9.2 / RubyGems 1.8.5 compatibility fix (pass String instead of Pathname to require)
@zdennis zdennis merged commit 92ec1b4 into zdennis:master Jun 23, 2011
@zdennis
Copy link
Owner

zdennis commented Jun 23, 2011

This was supposedly fixed in rubygems itself: https://github.com/rubygems/rubygems/tree/d8abe9b3a5cf0bc5bba495be5c9fbf0fada7586b

But that commit doesn't seem to be in rubygems/master and it's not in the 1.8.5 release.

@zdennis
Copy link
Owner

zdennis commented Jun 23, 2011

Actually it is rubygems/master, just not in the 1.8.5 tag.

@fallwith
Copy link
Contributor Author

Much obliged. Thanks very much for the quick response and info about the RubyGems commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants