Seamless database pool adapter #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdennis
added a commit
that referenced
this pull request
Aug 30, 2012
Seamless database pool adapter
|
@spectator, thanks for the commit. I have also committed the gemspec to the repository now. |
|
@zdennis thanks for pulling this in. BTW, how about to bump a new patch version and push it to rubygems? |
|
0.2.11 has just been pushed and this changeset is included. Thanks! |
|
Awesome. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dennis,
I put together a quick fix my colleague made to use activerecord-import with seamless_database_pool adapter. So now your gem could be used in MySQL master/slave environments.
Please let me know if you have questions.
P.S. Don't you think it makes sense to commit gemspec into repository? I know I can build it with Jeweler, however it's not obvious at first sight and having no gemspec in repo doesn't allow you to do