Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Seamless database pool adapter #62

Merged
merged 8 commits into from Aug 30, 2012

Conversation

Projects
None yet
2 participants
Contributor

spectator commented Aug 23, 2012

Hi Dennis,

I put together a quick fix my colleague made to use activerecord-import with seamless_database_pool adapter. So now your gem could be used in MySQL master/slave environments.

Please let me know if you have questions.

P.S. Don't you think it makes sense to commit gemspec into repository? I know I can build it with Jeweler, however it's not obvious at first sight and having no gemspec in repo doesn't allow you to do

gem "activerecord-import", git: "git://github.com/zdennis/activerecord-import.git"

zdennis added a commit that referenced this pull request Aug 30, 2012

@zdennis zdennis merged commit 75a63d7 into zdennis:master Aug 30, 2012

Owner

zdennis commented Aug 30, 2012

@spectator, thanks for the commit. I have also committed the gemspec to the repository now.

Contributor

spectator commented Sep 10, 2012

@zdennis thanks for pulling this in. BTW, how about to bump a new patch version and push it to rubygems?

Owner

zdennis commented Sep 14, 2012

0.2.11 has just been pushed and this changeset is included. Thanks!

Contributor

spectator commented Sep 14, 2012

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment