Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

‼ jq ftw #116

Merged
merged 7 commits into from
Nov 29, 2021
Merged

‼ jq ftw #116

merged 7 commits into from
Nov 29, 2021

Conversation

pschmitt
Copy link
Member

@pschmitt pschmitt commented Nov 28, 2021

⚠ JSON parsing using jq

Got rid of the very awkward in-house custom JSON parsing. The API stays more of less the same.

This is the breaking change

zinit requires jq! (only for the pack ice)

Also included

  • local packages.json files can now be loaded via absolute paths (relative ones already worked) or other repositories
  • zinit pack ver"my-branch" for mypackage works now as intended (the ver ice)
  • file:// URLs are now supported by .zinit-download-file-stdout. They kinda already were, provided you had curlor lynx installed (ie. not wget)

@pschmitt pschmitt added this to the zinit 4.0 milestone Nov 28, 2021
@pschmitt pschmitt added enhancement New feature or request breaking change Breaking changes packaging Issue related to packaging & distribution labels Nov 28, 2021
@pschmitt pschmitt changed the title jq ftw ‼ jq ftw Nov 28, 2021
pschmitt added a commit to zdharma-continuum/zinit-packages that referenced this pull request Nov 28, 2021
Copy link
Member

@alichtman alichtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this, UNIX philosophy and all.

@pschmitt
Copy link
Member Author

Once this and #112 land we can get some real ci going for the packages :)

@alichtman
Copy link
Member

Feel free to ship whenever

@pschmitt
Copy link
Member Author

Okay, here we go!

@pschmitt pschmitt merged commit 3318c31 into zdharma-continuum:main Nov 29, 2021
@pschmitt pschmitt deleted the jq-ftw branch November 29, 2021 08:53
@pschmitt pschmitt restored the jq-ftw branch November 30, 2021 10:57
@vladdoster
Copy link
Member

yeah this is a great change, thanks for implementing this.

@github-actions
Copy link

github-actions bot commented Nov 7, 2022

🎉 This PR is included in version 3.8.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Breaking changes enhancement New feature or request packaging Issue related to packaging & distribution released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants