Skip to content

Commit

Permalink
doc: Add Carbon ad to the welcome page
Browse files Browse the repository at this point in the history
  • Loading branch information
@trollixx
trollixx committed Aug 15, 2017
1 parent 4dcd7cf commit a90fef3
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions src/app/resources/browser/welcome.html
View file
Expand Up @@ -34,6 +34,9 @@ <h2 class="subtitle">
<div class="hero-foot">
<div class="container">
<div class="content has-text-centered">
<div id="carbon" class="box">
<script async type="text/javascript" src="https://cdn.carbonads.com/carbon.js?zoneid=1673&serve=C6AILKT&placement=zealdocsforwindowsorg" id="_carbonads_js"></script>
</div>
<p>
<a class="icon" href="https://github.com/zealdocs/zeal">
<i class="fa fa-github"></i>
Expand Down

2 comments on commit a90fef3

@barthalion
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be optionally disabled on build time? I don't want to cut it out without prior agreement; I understand that open source development being essentially free, especially for small projects, simply sucks, but embedding advisements in the official distribution package does so even more.

@trollixx
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit too late to add a build option for 0.4.0, but I am okay if you just revert this commit and potentially e2c576d, which adds a settings option to disable the ad.

I want to make it possible to update the welcome page on its own, so then I'd remove version with the ad from the source base.

If implementing that will be taking too long, I will add a build option to disable the ad completely for the next release.

Please sign in to comment.