feat(core): add option to ignore SSL errors #1521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://forum.qt.io/topic/125873/how-to-clear-qnetworkreply-ignoresslerrors Otherwise, if you try to disable the ignoring of SSL errors, the new ignore settings will not take immediate effect due to the keep-alive connection with the server.
trollixx
requested changes
Aug 6, 2023
src/libs/ui/settingsdialog.cpp
Outdated
Comment on lines
337
to
340
| if (settings->isIgnoreSSLErrorsEnabled != ui->ignoreSSLErrorsCheckBox->isChecked()) { | ||
| // https://forum.qt.io/topic/125873/how-to-clear-qnetworkreply-ignoresslerrors/2 | ||
| m_application->networkManager()->clearAccessCache(); | ||
| } |
There was a problem hiding this comment.
This is already done in Core::Application::applySettings, but needs to be moved outside of proxy selection switch.
src/libs/ui/docsetsdialog.cpp
Outdated
Comment on lines
679
to
685
| if (m_application->settings()->isIgnoreSSLErrorsEnabled) { | ||
| // Connect to the reply's sslErrors signal to handle SSL errors | ||
| connect(reply, &QNetworkReply::sslErrors, [=](const QList<QSslError>& errors){ | ||
| // Ignore all SSL errors | ||
| reply->ignoreSslErrors(); | ||
| }); | ||
| } |
There was a problem hiding this comment.
This signal should be handled on Core::NetworkAccessManager to cover all network activity performed by Zeal.
The easiest approach would probably be handling the signal in Core::Application, when network manager is created. Not the most elegant solution, but would avoid the need to pass settings into Core::NetworkAccessManager.
There was a problem hiding this comment.
You meant like this - b4e2c86 ? If so - done.
Closed
Closed
Co-authored-by: Oleg Shparber <trollixx@gmail.com>
Co-authored-by: Oleg Shparber <trollixx@gmail.com>
This reverts commit c851ede.
to correct handle of isIgnoreSSLErrorsEnabled, details: https://forum.qt.io/topic/125873/how-to-clear-qnetworkreply-ignoresslerrors/2
trollixx
approved these changes
Aug 6, 2023
trollixx
changed the title
Not at all, happy to assist! Thank you for providing those suggestions and explanations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds network settings to ignore SSL errors in order to handle the cases described here:
When the SSL certificate on the server is expired or invalid, users can still download from that server by choosing to ignore SSL errors.
If the project maintainers find this feature unacceptable, I apologize.