-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for SOCKS5 proxies #905
Conversation
Thanks for the contribution! Unless I missed something, I don't see any differences between HTTP and SOCKS5 code branches. I think it'd be better to have just one user defined setting, that accepts both types of proxies. Updating the preference dialog with a "HTTP or SOCKS5" label should work just fine. |
I wonder if there are any valid setups when independent settings for HTTP and SOCKS5 proxies would be required.. |
Yeah that one was easy to oversee and I believe the only one. AFAIK one can't setup up two proxies at the same time with qt so the only usecase I can think of would be a user who switches between http/socks proxy very often (for whatever reasons) and therefore wants them to be saved separately. |
It is possible with |
Sorry, I'm always getting seg faults when I try to use QNetworkProxyFactory::setApplicationProxyFactory, can you finish this PR as you would like it to be? |
I'd like to check if I can make |
This will go into 0.7 branch. |
How far off from a merge is this PR? I'm willing to give a hand in getting these feature merged, even if I'm not a C developer myself. |
I added SOCKS5 support in 4d019ff. It's pretty much similar to this PR, except that I implemented UI a bit differently. Regardless, thanks for the contribution! |
closes #893
I don't know how to easily update these hint coords, maybe someone can update them in a followup commit.