Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for SOCKS5 proxies #905

Closed
wants to merge 1 commit into from
Closed

add support for SOCKS5 proxies #905

wants to merge 1 commit into from

Conversation

Unpublished
Copy link

closes #893

I don't know how to easily update these hint coords, maybe someone can update them in a followup commit.

@trollixx
Copy link
Member

trollixx commented Mar 18, 2018

Thanks for the contribution!

Unless I missed something, I don't see any differences between HTTP and SOCKS5 code branches. I think it'd be better to have just one user defined setting, that accepts both types of proxies. Updating the preference dialog with a "HTTP or SOCKS5" label should work just fine.

@trollixx
Copy link
Member

I wonder if there are any valid setups when independent settings for HTTP and SOCKS5 proxies would be required..

@Unpublished
Copy link
Author

Yeah that one was easy to oversee and I believe the only one.

AFAIK one can't setup up two proxies at the same time with qt so the only usecase I can think of would be a user who switches between http/socks proxy very often (for whatever reasons) and therefore wants them to be saved separately.

@trollixx
Copy link
Member

trollixx commented Mar 19, 2018

It is possible with QNetworkProxyFactory. See a sample workflow here.

@Unpublished
Copy link
Author

Sorry, I'm always getting seg faults when I try to use QNetworkProxyFactory::setApplicationProxyFactory, can you finish this PR as you would like it to be?

@trollixx
Copy link
Member

I'd like to check if I can make QNetworkProxyFactory work, if not will just merge your change.

@trollixx
Copy link
Member

This will go into 0.7 branch.

@grooveadelic
Copy link

How far off from a merge is this PR? I'm willing to give a hand in getting these feature merged, even if I'm not a C developer myself.

@trollixx
Copy link
Member

trollixx commented Nov 6, 2018

I added SOCKS5 support in 4d019ff. It's pretty much similar to this PR, except that I implemented UI a bit differently. Regardless, thanks for the contribution!

@trollixx trollixx closed this Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Support SOCKS5 proxy
3 participants