Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add short-giraffe-theme extension #789

Merged
merged 9 commits into from
Aug 30, 2024
Merged

Conversation

Mehdi-Hp
Copy link
Contributor

No description provided.

Copy link

cla-bot bot commented May 26, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @Mehdi-Hp on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@Mehdi-Hp
Copy link
Contributor Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label May 26, 2024
Copy link

cla-bot bot commented May 26, 2024

The cla-bot has been summoned, and re-checked this pull request!

@Mehdi-Hp
Copy link
Contributor Author

@maxdeviant Can't figure out what went wrong

@maxdeviant
Copy link
Member

@maxdeviant Can't figure out what went wrong

It looks like the author field is missing:

https://github.com/zed-industries/extensions/actions/runs/9272269166/job/25509612076?pr=789#step:11:28

@Mehdi-Hp
Copy link
Contributor Author

@maxdeviant
Copy link
Member

Well, Yeah, but it's there https://github.com/Mehdi-Hp/Short-Giraffe/blob/b14f44bdffc2039706a2af947958e198dc48e645/extension.json

It's trying to load the vscode.json theme as a Zed theme, and complaining about the lack of the author field there: https://github.com/Mehdi-Hp/Short-Giraffe/blob/b14f44bdffc2039706a2af947958e198dc48e645/themes/vscode.json#L1-L4

Anything in the themes directory will be included as a theme when packaging the extension for Zed.

I would recommend creating a separate subdirectory in your repo to keep the Zed extension in.

@maxdeviant
Copy link
Member

Closing this out due to inactivity.

If you come back to this, feel free to re-open this PR.

@maxdeviant maxdeviant closed this Jul 1, 2024
@Mehdi-Hp
Copy link
Contributor Author

This should be good to go now

@maxdeviant maxdeviant reopened this Aug 26, 2024
@maxdeviant
Copy link
Member

@Mehdi-Hp It looks like the extension is using the old extension.json format.

Could you update it to use the new extension.toml format? https://zed.dev/docs/extensions/developing-extensions#directory-structure-of-a-zed-extension

@Mehdi-Hp
Copy link
Contributor Author

@maxdeviant Thanks for providing the link. Done

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant merged commit 9bc4693 into zed-industries:main Aug 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants