Skip to content

Commit

Permalink
Fix aside affecting parent popover height (#11859)
Browse files Browse the repository at this point in the history
Release Notes:

- Fixed the size of the completions menu changing based on the size of
the aside
([#11722](#11722)).


https://github.com/zed-industries/zed/assets/30776250/c67e6fef-20f2-4dc5-92b3-09bb73f874a7


https://github.com/zed-industries/zed/assets/30776250/7467b8ee-6e66-42d7-a8cc-2df11df58c5e

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
  • Loading branch information
loczek and maxdeviant committed May 15, 2024
1 parent 4ff1ee1 commit d3dfa91
Showing 1 changed file with 7 additions and 3 deletions.
10 changes: 7 additions & 3 deletions crates/ui/src/components/popover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,14 @@ pub struct Popover {

impl RenderOnce for Popover {
fn render(self, cx: &mut WindowContext) -> impl IntoElement {
div()
.flex()
h_flex()
.items_start()
.gap_1()
.child(v_flex().elevation_2(cx).px_1().children(self.children))
.child(
div()
.flex()
.child(v_flex().elevation_2(cx).px_1().children(self.children)),
)
.when_some(self.aside, |this, aside| {
this.child(
v_flex()
Expand Down

0 comments on commit d3dfa91

Please sign in to comment.