Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The additional documentation popover will change the height of the completions box #11722

Closed
1 task done
Moshyfawn opened this issue May 12, 2024 · 1 comment
Closed
1 task done
Labels
autocompletions Feedback for code completions in the editor defect [core label] editor Feedback for code editing, formatting, editor iterations, etc popovers Feedback for tooltips, syntax hints, info popups, etc

Comments

@Moshyfawn
Copy link
Contributor

Moshyfawn commented May 12, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

When the documentation popover is displayed, the height of the completion box is increased to accommodate the popover. This can cause jarring UI height changes when the popover is displayed and hidden. If the height of the documentation popover content is slightly greater than the height of the completion box, the completion box will appear broken / misaligned.

Example case: trigger IntoElement suggestions and navigate the suggestions popover.

Element, EventEmitter, IntoElement, ParentElement, Render, StyledText, Subscription,

Environment

Zed: v0.136.0 (Zed Nightly f550f23)
OS: macOS 14.4.1
Memory: 18 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

zed-ctx-popover-height.mp4

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@Moshyfawn Moshyfawn added defect [core label] editor Feedback for code editing, formatting, editor iterations, etc popovers Feedback for tooltips, syntax hints, info popups, etc admin read Pending admin review autocompletions Feedback for code completions in the editor labels May 12, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label May 13, 2024
maxdeviant added a commit that referenced this issue May 15, 2024
Release Notes:

- Fixed the size of the completions menu changing based on the size of
the aside
([#11722](#11722)).


https://github.com/zed-industries/zed/assets/30776250/c67e6fef-20f2-4dc5-92b3-09bb73f874a7


https://github.com/zed-industries/zed/assets/30776250/7467b8ee-6e66-42d7-a8cc-2df11df58c5e

---------

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
@JosephTLyons
Copy link
Contributor

This is now available in Zed v0.136.0-pre.

osiewicz pushed a commit to RemcoSmitsDev/zed that referenced this issue May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocompletions Feedback for code completions in the editor defect [core label] editor Feedback for code editing, formatting, editor iterations, etc popovers Feedback for tooltips, syntax hints, info popups, etc
Projects
None yet
Development

No branches or pull requests

2 participants