-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Position inline-git-blame information at column count #10555
Comments
That should be relatively easy.
|
Should be An interesting extension of this would be to snap to the lowest indent guide that is > line length + padding. |
Ah, except that logic makes it go out of view if the line is soft-wrapped (e.g. due to inlay hints making it longer than desired). In that case the blame should probably be moved to the last line of the soft-wrapped part. |
In #10600 I just added support for soft-wrapped lines (it was just broken before). It's now displayed next to each wrapped line, which I think makes sense when you think about the |
Hey, can i work on this ? |
@hshreekar sure, I linked to the code that needs to be edited above.
|
Release Notes: - Added a setting to determine the minimum column where the inline blame information is shown. Example: `{{"git": {"inline_blame": {"min_column": 80}}}` ([#10555](#10555)). Demo Video: https://github.com/zed-industries/zed/assets/1185253/61343dbe-9002-4bd1-b0d4-403f8da79050 --------- Co-authored-by: Thorsten Ball <mrnugget@gmail.com>
This landed in v0.133.0-pre today. Closing this out. |
Check for existing issues
Describe the feature
This is more of a "UI exploration" thing, I'm not sure yet if it's actually a good idea.
How about an option to constrain the inline git blame to a certain column position? I would consider setting it to never appear to the left of the first line wrap guide (80 cols in my config).
The motivation for this is to avoid causing a seemingly solid block of text when the cursor is on a short line between long lines (e.g. a paragraph break in a long comment)
If applicable, add mockups / screenshots to help present your vision of the feature
No response
The text was updated successfully, but these errors were encountered: