-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expected installation paths on Linux, name of cli binary #12585
Labels
Comments
jirutka
added
admin read
Pending admin review
enhancement
[core label]
triage
Maintainer needs to classify the issue
labels
Jun 2, 2024
FYI, I don't think this patch is doing what you're intending. It leaves the default settings intact until a user opens and saves the new ones. Better to patch the settings in this file, so that they'll be applied from first startup. |
ConradIrwin
added a commit
that referenced
this issue
Jun 4, 2024
ConradIrwin
added a commit
that referenced
this issue
Jun 4, 2024
ConradIrwin
added a commit
that referenced
this issue
Jun 4, 2024
ConradIrwin
added a commit
that referenced
this issue
Jun 4, 2024
ConradIrwin
added a commit
that referenced
this issue
Jun 4, 2024
mikayla-maki
added a commit
that referenced
this issue
Jun 4, 2024
Fixes #12585 This changes the expectations for installed binaries on linux based on work that @jirutka has done for Alpine. In particular, we now put the cli in place as `bin/zed` and the zed binary as `libexec/zed-editor`, and assume that packagers do the same. cc @someone13574 Release notes: - N/A --------- Co-authored-by: Mikayla <mikayla@zed.dev>
JosephTLyons
added
cli
Command-line interface feedback
linux
and removed
triage
Maintainer needs to classify the issue
admin read
Pending admin review
labels
Jun 4, 2024
algitbot
pushed a commit
to alpinelinux/aports
that referenced
this issue
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Check for existing issues
Describe the feature
If I understand it correctly,
cli
is supposed to be on PATH and used to launch theZed
UI from a terminal, right? However,cli
currently expectsZed
to be in the same directory ascli
and named eitherzed
orZed
. This meanscli
cannot be namedzed
(it essentially creates a fork-bomb…), which is quite unexpected.According to FHS,
cli
should be installed in thebin
directory (/bin
,/usr/bin
or/usr/local/bin
) to be on PATH andZed
(UI) most likely in thelibexec
directory (/usr/libexec
or/usr/local/libexec
).cli
is not a good name for a binary on PATH, it’s expected to be namedzed
.I’m packaging Zed for Alpine Linux (package, APKBUILD) and I had to patch
crates/cli/src/main.rs
to make it work as expected.If applicable, add mockups / screenshots to help present your vision of the feature
No response
The text was updated successfully, but these errors were encountered: