Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon gitlab extensions #12933

Closed
1 task done
Angelk90 opened this issue Jun 12, 2024 · 1 comment
Closed
1 task done

Icon gitlab extensions #12933

Angelk90 opened this issue Jun 12, 2024 · 1 comment
Labels
design [core label] enhancement [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc file icons Feedback for file icons visualisation, file type recognition, etc

Comments

@Angelk90
Copy link

Check for existing issues

  • Completed

Describe the feature

Url points to an address on gitlab but icon shown is that of github, it would be better to show gitlab icon.

image

If applicable, add mockups / screenshots to help present your vision of the feature

No response
@Angelk90 Angelk90 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jun 12, 2024
@Moshyfawn Moshyfawn added extension infrastructure Feedback for extensions APIs, creation, management, etc and removed triage Maintainer needs to classify the issue labels Jun 12, 2024
@notpeter notpeter added design [core label] file icons Feedback for file icons visualisation, file type recognition, etc and removed admin read Pending admin review labels Jun 12, 2024
@github-actions github-actions bot mentioned this issue Jun 12, 2024
Open
@bajrangCoder bajrangCoder mentioned this issue Jun 18, 2024
Closed
@Jonezzyboy Jonezzyboy mentioned this issue Jun 18, 2024
Closed
@maxdeviant
Copy link
Member

The GitHub icon here is a stand-in for a more generic "source code repository" icon.

We may swap it out for one in the future, but I don't think it's a stretch to use the GitHub icon to represent "repository", regardless of where it is hosted.

Having to support a bunch of different icons for various hosting services is going to make the extension cards look inconsistent from one another.

@maxdeviant maxdeviant closed this as not planned Won't fix, can't repro, duplicate, stale Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
design [core label] enhancement [core label] extension infrastructure Feedback for extensions APIs, creation, management, etc file icons Feedback for file icons visualisation, file type recognition, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@notpeter @maxdeviant @Moshyfawn @Angelk90