Support Additional Icons for Repo URLs in Extension Card #13196
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, Zed adds a
GitHub
icon for every extension repository URL, even if the repository isn't hosted on GitHub. This PR addresses that issue by determining the icon based on the repository URL using regex. For now, it adds aLink
icon for all repository URLs except those from GitHub.As @\maxdeviant mentioned, the Zed team isn't expecting icons from outside. Therefore, I've added a TODO note and temporarily applied the Link icon to the GitLab provider as well. Once the Zed team creates the appropriate icon, they can replace the Link icon with it.
Release Notes: