Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Additional Icons for Repo URLs in Extension Card #13196

Conversation

bajrangCoder
Copy link
Contributor

Currently, Zed adds a GitHub icon for every extension repository URL, even if the repository isn't hosted on GitHub. This PR addresses that issue by determining the icon based on the repository URL using regex. For now, it adds a Link icon for all repository URLs except those from GitHub.

As @\maxdeviant mentioned, the Zed team isn't expecting icons from outside. Therefore, I've added a TODO note and temporarily applied the Link icon to the GitLab provider as well. Once the Zed team creates the appropriate icon, they can replace the Link icon with it.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 18, 2024
@maxdeviant
Copy link
Member

We don’t want to use different icons for each extension entry.

Maybe using a GitHub icon isn’t the best choice—perhaps we could have a more generic “repository” icon—but I think there’s a pretty clear association between “GitHub” and “source code”.

@maxdeviant maxdeviant closed this Jun 18, 2024
@bajrangCoder
Copy link
Contributor Author

Hmm, That will good to use repository icon. 👍

—but I think there’s a pretty clear association between “GitHub” and “source code”.

But people also use gitlab(there are few zed extension hosted gitlab).

Note

Just tried to resolve this issue: #12933

@Angelk90
Copy link

clear association between “GitHub” and “source code”.

Not really if I see the github icon, I expect that if I click, the repository on github opens, nothing else.

#13204 It seemed like a good solution at the time.

However, if you want to use one icon for everyone to represent the repository, that might be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants