Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension gitlab icon support #13204

Closed

Conversation

Jonezzyboy
Copy link

Release Notes:

  • Added gitlab icon for extensions (#12933).

Screenshot:
image

Copy link

cla-bot bot commented Jun 18, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @Jonezzyboy on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@Jonezzyboy
Copy link
Author

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jun 18, 2024
Copy link

cla-bot bot commented Jun 18, 2024

The cla-bot has been summoned, and re-checked this pull request!

@maxdeviant maxdeviant self-assigned this Jun 18, 2024
@maxdeviant
Copy link
Member

We don’t want to use different icons for each extension entry.

Maybe using a GitHub icon isn’t the best choice—perhaps we could have a more generic “repository” icon—but I think there’s a pretty clear association between “GitHub” and “source code”.

@maxdeviant maxdeviant closed this Jun 18, 2024
@Jonezzyboy Jonezzyboy deleted the extension-gitlab-icon-support branch June 18, 2024 13:50
@Jonezzyboy
Copy link
Author

No worries 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants