Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linux Keybinding Improvements #14600

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Linux Keybinding Improvements #14600

merged 2 commits into from
Jul 17, 2024

Conversation

notpeter
Copy link
Member

@notpeter notpeter commented Jul 16, 2024 •
edited

  • Fixed ctrl-shift-d (duplicate line) conflict.
  • Fixes Linux: "Select Previous" and "Duplicate Line Down" have the same default keybinding #14458
  • Remove duplicate definition ctrl-shift-left/right (editor::SelectToPreviousWordStart)
  • Fix Expand/Shrink selection (was ctrl-shift-up/down, now alt-shift-left/right)
  • Add ctrl-f2 / cmd-f2 as alias for editor::SelectAllMatches matching VSCode
  • Moved multi-cursor (Insert cursor above / below) from ctrl-shift-up/down to alt-shift-up/down

Release Notes:

  • Improved Linux default keybindings (#14600).

@notpeter
linux keymap refinements
160c85c 
- Fixed ctrl-shift-d (duplicate line) conflict
- Remove duplicate definition `ctrl-shift-left/right` (editor::SelectToPreviousWordStart)
- Fix Expand/Shrink selection (was ctrl-shift-up/down, now alt-shift-left/right)
- Add `ctrl-f2` / `cmd-f2` as alias for `editor::SelectAllMatches` matching VSCode
- Moved multi-cursor (Insert cursor above / below) from ctrl-shift-up/down to alt-shift-up/down
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jul 16, 2024
@notpeter notpeter mentioned this pull request Jul 16, 2024
Closed
1 task
@notpeter
Copy link
Member Author

I can't test this at the moment (not near my Linux machine).
@xoich any chance you could verify my fix?

@maxdeviant maxdeviant changed the title Linux Keybinding Improvemnts Linux Keybinding Improvements Jul 16, 2024
@notpeter notpeter merged commit d1300b7 into main Jul 17, 2024
10 checks passed
@notpeter notpeter deleted the duplicate_duplicate_lines branch July 17, 2024 14:06
@sausir1
Copy link

sausir1 commented Jul 18, 2024

@notpeter Though this is merged, now with VSCode keybindings CTRL+D removes the line instead of selecting the next occurrence. I believe it worked fine before these changes.

notpeter added a commit that referenced this pull request Jul 26, 2024
@notpeter
Restore linux ctrl-d functionality broken in #14600.
8eaa317
@notpeter notpeter mentioned this pull request Jul 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux: "Select Previous" and "Duplicate Line Down" have the same default keybinding
2 participants
@notpeter @sausir1