Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File icons #5525

Closed
JosephTLyons opened this issue Jul 1, 2022 · 27 comments · Fixed by #2719
Closed

File icons #5525

JosephTLyons opened this issue Jul 1, 2022 · 27 comments · Fixed by #2719
Labels
design [core label] enhancement [core label] potential extension Functionality that could be implemented as an extension (consider moving to community extensions)

Comments

@JosephTLyons
Copy link
Contributor

JosephTLyons commented Jul 1, 2022

Is your feature request related to a problem? Please describe.
Something I would enjoy having in Zed would be file icons.

Describe the solution you'd like
The easiest route would be to just use the images that were used for Atom's File Icons plugin. The license permits these to be used in commercial software. A VS Code package was made with this image set as well, but I think VS Code may use a different set of images by default.

Places images could show up:

  • File Tree
  • Tabs
  • File Searcher
  • Anywhere else that displays file names?
@JosephTLyons JosephTLyons added the enhancement [core label] label Jul 1, 2022
@JosephTLyons JosephTLyons changed the title File Icons File icons Jul 1, 2022
@mikayla-maki mikayla-maki added the design [core label] label Aug 5, 2022
@kyjus25
Copy link

kyjus25 commented Jan 3, 2023

Alternatively, and preferably in my opinion, use the icons in vscode-material-icon-theme. 15M downloads speaks for itself, also licensed as MIT

Super excited for this feature (and phenominal job to the team thus far, btw!)

@jakobbouchard
Copy link

I also prefer the material icon theme, for what it's worth. I find it more consistent and better looking.

@totsteps
Copy link

There's also icons list from IntelliJ Platform UI Guidelines.

Not sure if they are up-to-date and require a license.

@Marcisbee
Copy link

For what it's worth, I think this is one of the best looking icon packs in the market. Might be usefull for this ticket https://github.com/miguelsolorio/vscode-symbols

@ghost
Copy link

ghost commented Feb 18, 2023

For what it's worth, I think this is one of the best looking icon packs in the market. Might be usefull for this ticket https://github.com/miguelsolorio/vscode-symbols

I second that. I used it with VSCode and oh my gosh it looked amazing. Simple and clean icons. Not overdone.

@kyjus25
Copy link

kyjus25 commented Feb 19, 2023

For what it's worth, I think this is one of the best looking icon packs in the market. Might be usefull for this ticket https://github.com/miguelsolorio/vscode-symbols

Tried it just now and yup, changing my answer. This is the one. Seems to have even more icons than Material Icon Theme! Thanks for the recommendation!

@jakobbouchard
Copy link

I'll also say that the Symbols icons look better! Disagree that there are more icons (I guess it depends what files you use), but they look more consistent, and it seems that more get added rather quickly!

@kyjus25
Copy link

kyjus25 commented Feb 19, 2023

@jakobbouchard For instance, for .component.ts files, Symbols specifically shows an Angular logo and Material only shows a TypeScript logo

@jakobbouchard
Copy link

I think that's not necessarily a missing icon, but more of a mapping issue maybe? Not sure actually. .component.ts files could also technically be used for something else than Angular, might be why. Anyways, doesn't matter, Symbols looks better haha

@jbergstroem
Copy link

jbergstroem commented Mar 16, 2023

Style-wise, quill icons (tweak of feather icons) seems to be a good fit:
https://github.com/cdonohue/vscode-quill-icons/raw/master/screenshots/demo-dark.png
https://github.com/cdonohue/vscode-quill-icons/raw/master/screenshots/demo-light.png

@jansol
Copy link
Contributor

jansol commented Mar 16, 2023

quill icons

I especially appreciate that those are monochrome and thus easily adaptable for any color scheme. (depending on what format they are defined in)

@hovsater hovsater added the potential extension Functionality that could be implemented as an extension (consider moving to community extensions) label Apr 30, 2023
@jakobbouchard
Copy link

Just to add one more option, the @catppuccin theme also has a sweet icon pack!

@mikayla-maki mikayla-maki mentioned this issue Jul 14, 2023
1 task
mikayla-maki referenced this issue Jul 19, 2023
This PR adds the next most requested editor feature.

TODO:
- [x] Figure out styles and icons for supported file types with

fixes https://github.com/zed-industries/community/issues/206

Release Notes:

- Added file icons
@JosephTLyons
Copy link
Contributor Author

JosephTLyons commented Jul 19, 2023

Hey everyone, a PR for file icons just landed on main today. Please open new issues for any follow-up stuff related to this feature request.

@jbergstroem
Copy link

jbergstroem commented Jul 19, 2023

@JosephTLyons out of curiosity: whats the process between main and what most people use (beta?)? Saw the bash issue close the other day and as a user there's a disconnect between something closed as "fixed" and being able to test it!

@iamnbutler
Copy link
Member

As we usually mention when closing most issues, the typical time from main to a stable release is 2 weeks.

Usually when something merges it will move to the preview channel in a week, and stable the next week if there are no issues/additional changes that need to be made.

Sometimes we catch issues and hold something back from being released, or certain features are developed on preview for longer than a week. It is a pretty manual process on the moment, and sometimes patch releases go out, so estimating the exact time until everyone on stable gets something is not very consistent.

We typically release on Wednesdays, so if something is merged Tuesday night you may get it in 8 days, etc.

@JosephTLyons
Copy link
Contributor Author

Hey @jbergstroem - we just published this today!

@acusti
Copy link

acusti commented Jul 28, 2023

the new file icons are great! thanks @mikayla-maki @JosephTLyons and anyone else involved in the release 🙇. the new visual language on the whole is very nice. i noticed that .json files have a database-like icon, which puzzled me, but i’m sure it’ll become familiar.

image

@JosephTLyons
Copy link
Contributor Author

the new file icons are great! thanks @mikayla-maki @JosephTLyons and anyone else involved in the release 🙇. the new visual language on the whole is very nice. i noticed that .json files have a database-like icon, which puzzled me, but i’m sure it’ll become familiar.

image

Glad to hear the positive feedback! Just to mention it, file icons are a work in progress. Derek is tweaking things and adding new icons here and there, so nothing is set in stone.

@terrysahaidak
Copy link

Trying out Zed right now and I found that it's really hard for me to navigate around without colorful icons. Very exited about this feature.

@pryley
Copy link

pryley commented Dec 8, 2023

I would love to see the Catppuccin icons in Zed.

@JosephTLyons JosephTLyons transferred this issue from zed-industries/community Jan 24, 2024
@zed-industries zed-industries deleted a comment from maxall41 Feb 12, 2024
@jackblackCH
Copy link

I love Zed and I deeply want to ditch VSCode, but I agree that file icons would improve the experience a lot and would make the switch easier.

@rodrigoherrerai
Copy link

I love Zed and I deeply want to ditch VSCode, but I agree that file icons would improve the experience a lot and would make the switch easier.

Second this. Colourful file icons and folders really needed

@alexandre-embie
Copy link

Please add material icon or similar to zed, the current monochrome is very hard to differentiate.

@ricardocarrola
Copy link

Yep. Agree. The monochrome won't work for visual detection of file types.

@anton-patrushev
Copy link

What's the status of it? Is there any way to install some custom icons from extensions or somehow else?

@Moshyfawn
Copy link
Contributor

What's the status of it? Is there any way to install some custom icons from extensions or somehow else?

This is the initial feature request for Zed to have file icons at all. As you can see, it has already been implemented and the issue is closed as complete. For custom file icons, be sure to follow #8843 and +👍.

@inoas
Copy link

inoas commented Apr 26, 2024

Colours is what I am looking for. Material icons etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design [core label] enhancement [core label] potential extension Functionality that could be implemented as an extension (consider moving to community extensions)
Projects
None yet
Development

Successfully merging a pull request may close this issue.