Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copilot accept keybinding #6788

Closed
1 task done
mbriggs opened this issue Jan 26, 2024 · 3 comments · Fixed by #12094
Closed
1 task done

Copilot accept keybinding #6788

mbriggs opened this issue Jan 26, 2024 · 3 comments · Fixed by #12094
Labels
ai Improvement related to Assistant, Copilot, or other AI features copilot AI feedback for Copilot enhancement [core label] inline completion keymap / key binding Feedback for keyboard shortcuts, key mapping, etc

Comments

@mbriggs
Copy link

mbriggs commented Jan 26, 2024

Check for existing issues

  • Completed

Describe the feature

I don't know if I'm the only one who interacts with copilot this way, but I find the biggest challenge of copilot is learning how to ignore it when the suggestions are bad. Something I find helps with that is separating out copilot accept into another key bind, instead of tying it to (autocomplete accept). Typically, I will use cmd+; for this. It would be cool if there was a way to set this independently if desired :)

Thank you, zed is super cool, really looking forward to seeing where it goes!

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@mbriggs mbriggs added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels Jan 26, 2024
@JosephTLyons JosephTLyons added keymap / key binding Feedback for keyboard shortcuts, key mapping, etc copilot AI feedback for Copilot and removed triage Maintainer needs to classify the issue admin read Pending admin review labels Jan 29, 2024
@JosephTLyons JosephTLyons added the ai Improvement related to Assistant, Copilot, or other AI features label Feb 29, 2024
@raphaelluethy
Copy link
Contributor

raphaelluethy commented May 10, 2024

Is there any progress on this issue? It would make my workflow so much easier :) At the moment I just don't use Copilot as having the accept on Tab just intervenes too much while typing :/

@ray-pH
Copy link

ray-pH commented May 14, 2024

Is there any progress on this issue? It would make my workflow so much easier :) At the moment I just don't use Copilot as having the accept on Tab just intervenes too much while typing :/

You can bind them to another keymap. Unfortunately, I don't think there's a dedicated action to accept copilot suggestions, but "editor::Tab" does the job for me. I'm currently using ctrl-j to accept Copilot's suggestion

"ctrl-j": "editor::Tab"

@raphaelluethy
Copy link
Contributor

Is there any progress on this issue? It would make my workflow so much easier :) At the moment I just don't use Copilot as having the accept on Tab just intervenes too much while typing :/

You can bind them to another keymap. Unfortunately, I don't think there's a dedicated action to accept copilot suggestions, but "editor::Tab" does the job for me. I'm currently using ctrl-j to accept Copilot's suggestion

"ctrl-j": "editor::Tab"

Thank you for your suggestion, the main issue I have is that I would like to deactivate accepting inline suggestions when pressing tab so that i can still press tab without accepting the suggestion.

SomeoneToIgnore pushed a commit that referenced this issue May 22, 2024
…#12094)

Release Notes:
- Added `editor::AcceptInlineCompletion` action (bound to Tab by
default) for accepting inline completions. ([6788](#6788))

---------

Signed-off-by: Raphael Lüthy <raphael.luethy@fhnw.ch>
Co-authored-by: Conrad Irvin <conrad@zed.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai Improvement related to Assistant, Copilot, or other AI features copilot AI feedback for Copilot enhancement [core label] inline completion keymap / key binding Feedback for keyboard shortcuts, key mapping, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants