Splitting pane with extensions tab open crashes Zed

[Moshyfawn]

Check for existing issues

• Completed

Describe the bug / provide steps to reproduce it

Attempting to open a split pane from the command palette when the Extensions tab is open results in a crash.

This happens with and without any extensions installed.

Environment

Zed: v0.123.1 (Zed Preview)
OS: macOS 14.2.1
Memory: 16 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

zed-extensions-split-crash.mp4

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

Expand Zed logs

2024-02-15T10:16:30-05:00 [INFO] ========== starting zed ========== 2024-02-15T10:16:30-05:00 [INFO] Opening main db 2024-02-15T10:16:30-05:00 [ERROR] crates/theme/src/settings.rs:344: theme not found: Vesper 2024-02-15T10:16:30-05:00 [ERROR] crates/theme/src/settings.rs:212: theme not found: Vesper 2024-02-15T10:16:30-05:00 [INFO] Opening main db 2024-02-15T10:16:30-05:00 [ERROR] /Users/administrator/actions-runner-2/_work/zed/zed/crates/theme/src/registry.rs:270: expected value at line 1 column 1 2024-02-15T10:16:30-05:00 [INFO] build git repository ".git" 2024-02-15T10:16:30-05:00 [INFO] set status on client 0: Authenticating 2024-02-15T10:16:31-05:00 [INFO] set environment variables from shell:/bin/zsh, path:/opt/homebrew/bin:/opt/homebrew/sbin:/usr/local/bin:/System/Cryptexes/App/usr/bin:/usr/bin:/bin:/usr/sbin:/sbin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/local/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/bin:/var/run/com.apple.security.cryptexd/codex.system/bootstrap/usr/appleinternal/bin:/Library/Apple/usr/bin://.fig/bin://.local/bin://.orbstack/bin://.local/share/mise/shims://.modular/pkg/packages.modular.com_mojo/bin 2024-02-15T10:16:31-05:00 [INFO] set status on client 57425: Connecting 2024-02-15T10:16:31-05:00 [INFO] Opening main db 2024-02-15T10:16:31-05:00 [INFO] connected to rpc endpoint https://collab.zed.dev/rpc 2024-02-15T10:16:31-05:00 [INFO] Node runtime install_if_needed 2024-02-15T10:16:31-05:00 [INFO] add connection to peer 2024-02-15T10:16:31-05:00 [INFO] waiting for server hello 2024-02-15T10:16:31-05:00 [INFO] got server hello 2024-02-15T10:16:31-05:00 [INFO] set status to connected (connection id: ConnectionId { owner_id: 0, id: 0 }, peer id: PeerId { owner_id: 332, id: 609161 }) 2024-02-15T10:16:31-05:00 [INFO] set status on client 57425: Connected { peer_id: PeerId { owner_id: 332, id: 609161 }, connection_id: ConnectionId { owner_id: 0, id: 0 } } 2024-02-15T10:16:32-05:00 [INFO] 0 unhandled notification LogMessage: { "level": 0, "message": "[DEBUG] [agent] [2024-02-15T15:16:32.355Z] Agent service starting", "metadataStr": "[DEBUG] [agent] [2024-02-15T15:16:32.355Z]", "extra": [ "Agent service starting" ] } 2024-02-15T10:16:32-05:00 [INFO] 0 unhandled notification client/registerCapability: { "registrations": [ { "id": "7739cf44-0f90-40b4-96e6-e6696a9df033", "method": "workspace/didChangeWorkspaceFolders", "registerOptions": {} } ] } 2024-02-15T10:16:32-05:00 [INFO] 0 unhandled notification LogMessage: { "level": 0, "message": "[DEBUG] [agent] [2024-02-15T15:16:32.672Z] Telemetry initialized", "metadataStr": "[DEBUG] [agent] [2024-02-15T15:16:32.672Z]", "extra": [ "Telemetry initialized" ] } 2024-02-15T10:17:39-05:00 [ERROR] { "thread": "main", "payload": "assertion failed: self.window.next_frame.reused_views.insert(view_id)", "location_data": { "file": "crates/gpui/src/window/element_cx.rs", "line": 322 }, "backtrace": [ "::create", "::new", "Zed::init_panic_hook::{closure#0}", "std::panicking::rust_panic_with_hook", "std::panicking::begin_panic_handler::{{closure}}", "std::sys_common::backtrace::__rust_end_short_backtrace", "_rust_begin_unwind", "core::panicking::panic_fmt", "core::panicking::panic", "::reuse_view", "::paint", ">::paint::{closure#0}", ">::paint", "> as gpui::element::ElementObject>::paint", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}::{closure#0}", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}", "::paint", ">::paint", "> as gpui::element::ElementObject>::draw", "::paint", ">::paint", "> as gpui::element::ElementObject>::paint", ">::paint", "> as gpui::element::ElementObject>::paint", ">::paint", "> as gpui::element::ElementObject>::paint", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}::{closure#0}", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}", "::paint", ">::paint", "> as gpui::element::ElementObject>::paint", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}::{closure#0}", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}", "::paint", ">::paint", "> as gpui::element::ElementObject>::paint", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}::{closure#0}", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}", "::paint", ">>::paint::{closure#0}", "::with_element_state::>>::paint::{closure#0}>::{closure#0}", ">>::paint", ">> as gpui::element::ElementObject>::paint", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}::{closure#0}", "::paint::<::paint::{closure#0}>::{closure#2}::{closure#0}::{closure#0}", "::paint", ">::paint", "> as gpui::element::ElementObject>::paint", "::draw::{closure#0}", "::draw", "::draw", "::new::{closure#0}::{closure#1}", "::new::{closure#0}", "gpui::platform::mac::window::step", "::run", "Zed::main", "std::sys_common::backtrace::__rust_begin_short_backtrace::", "std::rt::lang_start::<()>::{closure#0}", "std::rt::lang_start_internal", "_main" ], "app_version": "0.123.1", "release_channel": "Zed Preview", "os_name": "macOS", "os_version": "14.2.1", "architecture": "aarch64", "panicked_on": 1708010259777, "installation_id": "5a42fa36-7f10-4924-b350-cf41bd59ae2a", "session_id": "ecab9f5a-abee-4b2a-907c-d81bca6837b6" }

[JosephTLyons]

Nice catch @Moshyfawn!

[maxbrunsfeld]

Thanks for the report @Moshyfawn. The fix has shipped in the latest preview.