Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

project panel Expand folder display error #9729

Closed
1 task done
0x2CA opened this issue Mar 23, 2024 · 2 comments · Fixed by #10221
Closed
1 task done

project panel Expand folder display error #9729

0x2CA opened this issue Mar 23, 2024 · 2 comments · Fixed by #10221
Labels
defect [core label] project panel Feedback for files tree view

Comments

@0x2CA
Copy link

0x2CA commented Mar 23, 2024

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

2024-03-23.13.04.09.mov

Environment

Zed: v0.128.1 (Zed Preview)
OS: macOS 14.2.1
Memory: 32 GiB
Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response
@0x2CA 0x2CA added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Mar 23, 2024
@Moshyfawn Moshyfawn added project panel Feedback for files tree view and removed triage Maintainer needs to classify the issue labels Mar 23, 2024
@d1y
Copy link
Contributor

d1y commented Mar 23, 2024

Maybe it's the same problem 😵‍💫

Zed: v0.128.1 (Zed Preview)
OS: macOS 14.4.0
Memory: 16 GiB
Architecture: aarch64

fixx

@github-actions github-actions bot mentioned this issue Mar 24, 2024
Open
@alwayrun
Copy link

The same issue exists. After some testing, it seems to be related to directory naming. When the directory name is in the format of a.b.c, the problem can be reproduced as described above.

Zed: v0.127.4
OS: macOS 13.6.3
Memory: 16 GiB
Architecture: x86_64

@JosephTLyons JosephTLyons removed the admin read Pending admin review label Mar 26, 2024
@Congyuwang Congyuwang mentioned this issue Apr 6, 2024
Closed
1 task
@weartist weartist mentioned this issue Apr 6, 2024
Merged
mikayla-maki pushed a commit that referenced this issue Apr 8, 2024
@weartist
Adjust string splitting function (#10221)
5e44748 
- Fixed #9729 and #10193

This commit fixes an issue where the string splitting function was
handling characters in the input string improperly. We adjusted the use
of the `take_while` function to calculate the length of the numeric
prefix, rather than directly splitting the string, thus correctly
splitting the string into a numeric prefix part and the remaining part
@JsGjKJzi JsGjKJzi mentioned this issue Apr 10, 2024
Merged
maxdeviant added a commit that referenced this issue Apr 10, 2024
@JsGjKJzi @maxdeviant
Add a few tests to cover other folder names (#10356)
b0eda77 
Added additional tests to cover other folder names in regards to
[#10193](#10193) and
[#9729](#9729).

I had a similar issue but with folder names like '2.5' and '2.5_backup'.
I didn't see test coverage for those kinds of file names, so wanted to
add them.

![2024-04-10 09 07
03](https://github.com/zed-industries/zed/assets/127535196/eef26ce2-b0c7-4b1f-98ed-426ce1df0af2)

Release Notes:

- N/A

Co-authored-by: Marshall Bowers <elliott.codes@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect [core label] project panel Feedback for files tree view
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust string splitting function weartist/zed
5 participants
@alwayrun @Moshyfawn @JosephTLyons @0x2CA @d1y