Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust string splitting function #10221

Merged
merged 2 commits into from Apr 8, 2024

Conversation

weartist
Copy link
Contributor

@weartist weartist commented Apr 6, 2024

This commit fixes an issue where the string splitting function was handling characters in the input string improperly. We adjusted the use of the take_while function to calculate the length of the numeric prefix, rather than directly splitting the string, thus correctly splitting the string into a numeric prefix part and the remaining part

Release Notes:

This commit fixes an issue where the string splitting function was handling characters in the input string improperly. We adjusted the use of the `take_while` function to calculate the length of the numeric prefix, rather than directly splitting the string, thus correctly splitting the string into a numeric prefix part and the remaining part.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 6, 2024
@mikayla-maki mikayla-maki merged commit 5e44748 into zed-industries:main Apr 8, 2024
8 checks passed
@mikayla-maki
Copy link
Contributor

Thank you!

@JosephTLyons
Copy link
Contributor

Hey @weartist, can you make sure that you keep the release notes section at the end of every PR and to fill it out? We have a script that runs on Wednesday that looks specifically for this section when building the release notes - when it gets removed, we have to hunt down these pull requests and build the release notes by hand.

Release Notes:

- Added/Fixed/Improved ... ([#<public_issue_number_if_exists>](https://github.com/zed-industries/zed/issues/<public_issue_number_if_exists>)).

Here's an example of it being filled out:

@weartist
Copy link
Contributor Author

Hey @weartist, can you make sure that you keep the release notes section at the end of every PR and to fill it out? We have a script that runs on Wednesday that looks specifically for this section when building the release notes - when it gets removed, we have to hunt down these pull requests and build the release notes by hand.

Release Notes:

- Added/Fixed/Improved ... ([#<public_issue_number_if_exists>](https://github.com/zed-industries/zed/issues/<public_issue_number_if_exists>)).

Here's an example of it being filled out:

No problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

project panel Expand folder display error
3 participants