Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hello_world in gpui's example doesn't work #9985

Closed
1 task done
JusufGaa opened this issue Mar 30, 2024 · 9 comments
Closed
1 task done

hello_world in gpui's example doesn't work #9985

JusufGaa opened this issue Mar 30, 2024 · 9 comments
Labels
defect [core label] documentation [core label] gpui GPUI rendering framework support

Comments

@JusufGaa
Copy link

Check for existing issues

  • Completed

Describe the bug / provide steps to reproduce it

It compiles fine, but there is no window after running it.

Environment

cargo run --example hello_world
macOS 12.2.1
Darwin 21.3.0

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

No response

@JusufGaa JusufGaa added admin read Pending admin review defect [core label] triage Maintainer needs to classify the issue labels Mar 30, 2024
@petros
Copy link
Contributor

petros commented Mar 30, 2024

Just as an extra data point, it runs fine on macOS Sonoma 14.2.1.

@MatinAniss
Copy link
Contributor

macOS 11.7.10

Getting no window but this info in console: invalid pixel format 70.

This issue seems like it started occurring after #9836
Probably due to the changes from BGRA8 to RGBA8, not sure why this breaks older mac versions since MTLPixelFormatRGBA8Unorm is supported for macOS 10.11+ which is the same as MTLPixelFormatBGRA8Unorm.

@Moshyfawn Moshyfawn added documentation [core label] gpui GPUI rendering framework support and removed triage Maintainer needs to classify the issue labels Apr 1, 2024
@JusufGaa
Copy link
Author

JusufGaa commented Apr 1, 2024

@MatinAniss @petros I'm trying to update my macOS to 13.6.6.
I'll let you know later if this works.

@JusufGaa
Copy link
Author

JusufGaa commented Apr 1, 2024

@MatinAniss @petros
It works, after I upgraded to 13.6.6

@JosephTLyons JosephTLyons removed the admin read Pending admin review label Apr 1, 2024
@JosephTLyons
Copy link
Contributor

I'm not sure what we should do here. To my knowledge, GPUI isn't established enough as a standalone library, outside of Zed, for us to have guarantees about which past OSes it supports. We know it works on everything new, as we are constantly using it, but as for past OSes, it isn't clear. Maybe its ok to just close this for now?

@MatinAniss
Copy link
Contributor

This issue affects 12.2.1 (highest currently confirmed) which is not that old (around 2 years ago), I wouldn't be surprised if this issue would affect a significant amount of existing users. Some of which cannot update to a higher version due to their aging hardware.

@mikayla-maki
Copy link
Contributor

Hi y'all, any chance y'all could test out #10089 and confirm for me that this fixes the issue? Thanks!

@Moshyfawn Moshyfawn added the needs info / awaiting response Issue that needs more information from the user label Apr 2, 2024
ConradIrwin pushed a commit that referenced this issue Apr 2, 2024
Due to: #9985 and an
abundance of caution, I'm reverting the image and svg rendering updates
for now until we can debug the issue. cc: @niklaswimmer

Release Notes:

- N/A
@MatinAniss
Copy link
Contributor

MatinAniss commented Apr 2, 2024

macOS 11.7.10

@mikayla-maki It is running fine again but now for some reason the size of the window and the rendered size is wrong. I guess thats how its supposed to be rendered actually.

Screen Shot 2024-04-03 at 10 28 45 am

@mikayla-maki
Copy link
Contributor

That’s correct for the sample code :) It’s not a very stylish hello world yet!

@JosephTLyons JosephTLyons removed the needs info / awaiting response Issue that needs more information from the user label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect [core label] documentation [core label] gpui GPUI rendering framework support
Projects
None yet
Development

No branches or pull requests

6 participants