Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: remoting #10085

Merged
merged 43 commits into from
Apr 11, 2024
Merged

WIP: remoting #10085

merged 43 commits into from
Apr 11, 2024

Conversation

ConradIrwin
Copy link
Collaborator

Release Notes:

Optionally, include screenshots / media showcasing your addition that can be included in the release notes.

or

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Apr 2, 2024
Copy link

github-actions bot commented Apr 2, 2024

Squawk Report

🚒 1 violations across 1 file(s)


crates/collab/migrations/20240402155003_add_dev_server_projects.sql

CREATE TABLE remote_projects (
    id INT PRIMARY KEY GENERATED ALWAYS AS IDENTITY,
    channel_id INT NOT NULL REFERENCES channels(id),
    dev_server_id INT NOT NULL REFERENCES dev_servers(id),
    name TEXT NOT NULL,
    path TEXT NOT NULL
);

ALTER TABLE projects ADD COLUMN remote_project_id INTEGER REFERENCES remote_projects(id);

🚒 Rule Violations (1)

crates/collab/migrations/20240402155003_add_dev_server_projects.sql:8:2: warning: adding-foreign-key-constraint

   8 | ALTER TABLE projects ADD COLUMN remote_project_id INTEGER REFERENCES remote_projects(id);

  note: Requires a table scan of the table you're altering and a SHARE ROW EXCLUSIVE lock on both tables, which blocks writes to both tables while your table is scanned.
  help: Add NOT VALID to the constraint in one transaction and then VALIDATE the constraint in a separate transaction.

📚 More info on rules

⚡️ Powered by Squawk (0.26.0), a linter for PostgreSQL, focused on migrations

Co-Authored-By: Bennet <bennetbo@gmx.de>
@davidbarsky
Copy link

Oh man, congratulations on getting this up!

ConradIrwin and others added 8 commits April 3, 2024 14:58
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com>
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com>
Co-Authored-By: Conrad Irwin <conrad.irwin@gmail.com>
Co-authored-by: Conrad <conrad@zed.dev>
Co-authored-by: Nathan <nathan@zed.dev>
ConradIrwin and others added 9 commits April 4, 2024 13:27
Co-Authored-By: Nathan <nathan@zed.dev>
Co-Authored-By: Bennet <bennetbo@gmx.de>
Co-Authored-By: Nathan <nathan@zed.dev>
Related: tokio-rs/tracing#2927

Co-Authored-By: Nathan <nathan@zed.dev>
Co-Authored-By: Conrad <conrad@zed.dev>
Co-Authored-By: Conrad <conrad@zed.dev>
Co-authored-by: Conrad <conrad@zed.dev>
@ConradIrwin ConradIrwin force-pushed the remote-project branch 4 times, most recently from a377792 to c1b878a Compare April 9, 2024 14:42
@ConradIrwin ConradIrwin force-pushed the remote-project branch 2 times, most recently from c07635a to 79ee651 Compare April 9, 2024 19:51
@ConradIrwin ConradIrwin merged commit f6c85b2 into main Apr 11, 2024
8 checks passed
@ConradIrwin ConradIrwin deleted the remote-project branch April 11, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants